Fixed entry resolving while processing incoming notify packets,
[silc.git] / lib / silcclient / client_entry.c
index 980daea66746322437b3119d7f1fcd7026a99e7a..1cc1833709b635c20ad0e7bf1d9bbbbe4d158fbb 100644 (file)
@@ -4,7 +4,7 @@
 
   Author: Pekka Riikonen <priikone@silcnet.org>
 
-  Copyright (C) 2001 - 2006 Pekka Riikonen
+  Copyright (C) 2001 - 2007 Pekka Riikonen
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -136,6 +136,7 @@ typedef struct {
   SilcDList clients;
   SilcGetClientCallback completion;
   void *context;
+  SilcClientEntry client_entry;
 } *SilcClientGetClientInternal;
 
 /* Resolving command callback */
@@ -153,6 +154,12 @@ static SilcBool silc_client_get_clients_cb(SilcClient client,
 
   if (error != SILC_STATUS_OK) {
     SILC_LOG_DEBUG(("Resolving failed: %s", silc_get_status_message(error)));
+
+    if (i->client_entry) {
+      i->client_entry->internal.resolve_cmd_ident = 0;
+      silc_client_unref_client(client, conn, i->client_entry);
+    }
+
     if (i->completion)
       i->completion(client, conn, error, NULL, i->context);
     goto out;
@@ -170,6 +177,12 @@ static SilcBool silc_client_get_clients_cb(SilcClient client,
     /* Deliver the clients to the caller */
     if (i->completion) {
       SILC_LOG_DEBUG(("Resolved %d clients", silc_dlist_count(i->clients)));
+
+      if (i->client_entry) {
+       i->client_entry->internal.resolve_cmd_ident = 0;
+       silc_client_unref_client(client, conn, i->client_entry);
+      }
+
       silc_dlist_start(i->clients);
       i->completion(client, conn, SILC_STATUS_OK, i->clients, i->context);
     }
@@ -236,10 +249,13 @@ silc_client_get_client_by_id_resolve(SilcClient client,
   if (!cmd_ident && completion)
     completion(client, conn, SILC_STATUS_ERR_RESOURCE_LIMIT, NULL, context);
 
-  if (client_entry && cmd_ident)
+  if (client_entry && cmd_ident) {
     client_entry->internal.resolve_cmd_ident = cmd_ident;
+    i->client_entry = client_entry;
+  } else {
+    silc_client_unref_client(client, conn, client_entry);
+  }
 
-  silc_client_unref_client(client, conn, client_entry);
   silc_buffer_free(idp);
 
   return cmd_ident;
@@ -423,6 +439,7 @@ SilcUInt16 silc_client_get_clients_by_list(SilcClient client,
   SilcUInt32 *res_argv_lens = NULL, *res_argv_types = NULL, res_argc = 0;
   SilcUInt16 idp_len, cmd_ident;
   SilcID id;
+  va_list tmp;
   int i;
 
   SILC_LOG_DEBUG(("Resolve clients from Client ID list"));
@@ -490,7 +507,7 @@ SilcUInt16 silc_client_get_clients_by_list(SilcClient client,
 
   /* We have the clients in cache, get them and call the completion */
   silc_client_get_clients_list_cb(client, conn, SILC_COMMAND_WHOIS,
-                                 SILC_STATUS_OK, SILC_STATUS_OK, in, NULL);
+                                 SILC_STATUS_OK, SILC_STATUS_OK, in, tmp);
   return 0;
 
  err:
@@ -695,9 +712,9 @@ SilcClientEntry silc_client_add_client(SilcClient client,
   if (!client_entry)
     return NULL;
 
+  silc_rwlock_alloc(&client_entry->internal.lock);
   silc_atomic_init8(&client_entry->internal.refcnt, 0);
   client_entry->id = *id;
-  client_entry->internal.valid = TRUE;
   client_entry->mode = mode;
   client_entry->realname = userinfo ? strdup(userinfo) : NULL;
   silc_parse_userfqdn(nickname, client_entry->nickname,
@@ -729,9 +746,6 @@ SilcClientEntry silc_client_add_client(SilcClient client,
     }
   }
 
-  /* Format the nickname */
-  silc_client_nickname_format(client, conn, client_entry);
-
   silc_mutex_lock(conn->internal->lock);
 
   /* Add client to cache, the normalized nickname is saved to cache */
@@ -750,12 +764,19 @@ SilcClientEntry silc_client_add_client(SilcClient client,
   silc_mutex_unlock(conn->internal->lock);
   silc_client_ref_client(client, conn, client_entry);
 
-  SILC_LOG_DEBUG(("Added"));
+  /* Format the nickname */
+  silc_client_nickname_format(client, conn, client_entry, FALSE);
+
+  if (client_entry->nickname[0])
+    client_entry->internal.valid = TRUE;
+
+  SILC_LOG_DEBUG(("Added %p", client_entry));
 
   return client_entry;
 }
 
-/* Updates the `client_entry' with the new information sent as argument. */
+/* Updates the `client_entry' with the new information sent as argument.
+   This handles entry locking internally. */
 
 void silc_client_update_client(SilcClient client,
                               SilcClientConnection conn,
@@ -769,6 +790,8 @@ void silc_client_update_client(SilcClient client,
 
   SILC_LOG_DEBUG(("Update client entry"));
 
+  silc_rwlock_wrlock(client_entry->internal.lock);
+
   if (!client_entry->realname && userinfo)
     client_entry->realname = strdup(userinfo);
   if ((!client_entry->username[0] || !client_entry->hostname[0]) && username)
@@ -786,11 +809,14 @@ void silc_client_update_client(SilcClient client,
     nick = silc_identifier_check(client_entry->nickname,
                                 strlen(client_entry->nickname),
                                 SILC_STRING_UTF8, 128, NULL);
-    if (!nick)
+    if (!nick) {
+      silc_rwlock_unlock(client_entry->internal.lock);
       return;
+    }
 
     /* Format nickname */
-    silc_client_nickname_format(client, conn, client_entry);
+    silc_client_nickname_format(client, conn, client_entry,
+                               client_entry == conn->local_entry);
 
     /* Update cache entry */
     silc_mutex_lock(conn->internal->lock);
@@ -798,8 +824,63 @@ void silc_client_update_client(SilcClient client,
                                   client_entry, NULL, nick, TRUE);
     silc_mutex_unlock(conn->internal->lock);
     client_entry->nickname_normalized = nick;
+    client_entry->internal.valid = TRUE;
   }
   client_entry->mode = mode;
+
+  silc_rwlock_unlock(client_entry->internal.lock);
+}
+
+/* Change a client's nickname.  Must be called with `client_entry' locked. */
+
+SilcBool silc_client_change_nickname(SilcClient client,
+                                    SilcClientConnection conn,
+                                    SilcClientEntry client_entry,
+                                    const char *new_nick,
+                                    SilcClientID *new_id,
+                                    const unsigned char *idp,
+                                    SilcUInt32 idp_len)
+{
+  char *tmp;
+
+  SILC_LOG_DEBUG(("Change nickname %s to %s", client_entry->nickname,
+                 new_nick));
+
+  /* Normalize nickname */
+  tmp = silc_identifier_check(new_nick, strlen(new_nick),
+                             SILC_STRING_UTF8, 128, NULL);
+  if (!tmp)
+    return FALSE;
+
+  /* Update the client entry */
+  silc_mutex_lock(conn->internal->lock);
+  if (!silc_idcache_update_by_context(conn->internal->client_cache,
+                                     client_entry, new_id, tmp, TRUE)) {
+    silc_free(tmp);
+    silc_mutex_unlock(conn->internal->lock);
+    return FALSE;
+  }
+  silc_mutex_unlock(conn->internal->lock);
+
+  memset(client_entry->nickname, 0, sizeof(client_entry->nickname));
+  memcpy(client_entry->nickname, new_nick, strlen(new_nick));
+  client_entry->nickname_normalized = tmp;
+  silc_client_nickname_format(client, conn, client_entry,
+                             client_entry == conn->local_entry);
+
+  /* For my client entry, update ID and set new ID to packet stream */
+  if (client_entry == conn->local_entry) {
+    if (idp && idp_len) {
+      silc_buffer_enlarge(conn->internal->local_idp, idp_len);
+      silc_buffer_put(conn->internal->local_idp, idp, idp_len);
+    }
+    if (new_id)
+      silc_packet_set_ids(conn->stream, SILC_ID_CLIENT, conn->local_id,
+                         0, NULL);
+  }
+
+  client_entry->internal.valid = TRUE;
+  return TRUE;
 }
 
 /* Deletes the client entry and frees all memory. */
@@ -828,6 +909,7 @@ void silc_client_del_client_entry(SilcClient client,
     silc_client_abort_key_agreement(client, conn, client_entry);
 #endif /* 0 */
   silc_atomic_uninit8(&client_entry->internal.refcnt);
+  silc_rwlock_free(client_entry->internal.lock);
   silc_free(client_entry);
 }
 
@@ -862,15 +944,52 @@ SilcBool silc_client_del_client(SilcClient client, SilcClientConnection conn,
   return ret;
 }
 
+/* Internal routine used to find client by ID and if not found this creates
+   new client entry and returns it. */
+
+SilcClientEntry silc_client_get_client(SilcClient client,
+                                      SilcClientConnection conn,
+                                      SilcClientID *client_id)
+{
+  SilcClientEntry client_entry;
+
+  client_entry = silc_client_get_client_by_id(client, conn, client_id);
+  if (!client_entry) {
+    client_entry = silc_client_add_client(client, conn, NULL, NULL, NULL,
+                                         client_id, 0);
+    if (!client_entry)
+      return NULL;
+    silc_client_ref_client(client, conn, client_entry);
+  }
+
+  return client_entry;
+}
+
+/* Lock client */
+
+void silc_client_lock_client(SilcClientEntry client_entry)
+{
+  silc_rwlock_rdlock(client_entry->internal.lock);
+}
+
+/* Unlock client */
+
+void silc_client_unlock_client(SilcClientEntry client_entry)
+{
+  silc_rwlock_unlock(client_entry->internal.lock);
+}
+
 /* Take reference of client entry */
 
-void silc_client_ref_client(SilcClient client, SilcClientConnection conn,
-                           SilcClientEntry client_entry)
+SilcClientEntry silc_client_ref_client(SilcClient client,
+                                      SilcClientConnection conn,
+                                      SilcClientEntry client_entry)
 {
   silc_atomic_add_int8(&client_entry->internal.refcnt, 1);
   SILC_LOG_DEBUG(("Client %p refcnt %d->%d", client_entry,
                  silc_atomic_get_int8(&client_entry->internal.refcnt) - 1,
                  silc_atomic_get_int8(&client_entry->internal.refcnt)));
+  return client_entry;
 }
 
 /* Release reference of client entry */
@@ -905,11 +1024,13 @@ void silc_client_list_free(SilcClient client, SilcClientConnection conn,
 /* Formats the nickname of the client specified by the `client_entry'.
    If the format is specified by the application this will format the
    nickname and replace the old nickname in the client entry. If the
-   format string is not specified then this function has no effect. */
+   format string is not specified then this function has no effect.
+   Returns the client entry that was formatted. */
 
-void silc_client_nickname_format(SilcClient client,
-                                SilcClientConnection conn,
-                                SilcClientEntry client_entry)
+SilcClientEntry silc_client_nickname_format(SilcClient client,
+                                           SilcClientConnection conn,
+                                           SilcClientEntry client_entry,
+                                           SilcBool priority)
 {
   char *cp;
   char newnick[128 + 1];
@@ -918,21 +1039,25 @@ void silc_client_nickname_format(SilcClient client,
   SilcDList clients;
   SilcClientEntry entry, unformatted = NULL;
 
-  SILC_LOG_DEBUG(("Start"));
-
   if (!client->internal->params->nickname_format[0])
-    return;
-
+    return client_entry;
   if (!client_entry->nickname[0])
-    return;
+    return NULL;
+
+  SILC_LOG_DEBUG(("Format nickname"));
 
   /* Get all clients with same nickname. Do not perform the formatting
      if there aren't any clients with same nickname unless the application
      is forcing us to do so. */
   clients = silc_client_get_clients_local(client, conn,
                                          client_entry->nickname, NULL);
-  if (!clients && !client->internal->params->nickname_force_format)
-    return;
+  if (!clients)
+    return NULL;
+  if (silc_dlist_count(clients) == 1 &&
+      !client->internal->params->nickname_force_format) {
+    silc_client_list_free(client, conn, clients);
+    return client_entry;
+  }
 
   len = 0;
   freebase = TRUE;
@@ -943,15 +1068,16 @@ void silc_client_nickname_format(SilcClient client,
        silc_utf8_strcasecmp(entry->nickname, client_entry->nickname)) {
       freebase = FALSE;
       unformatted = entry;
+      break;
     }
   }
-  if (!len || freebase)
-    return;
+  if (!len || freebase) {
+    silc_client_list_free(client, conn, clients);
+    return client_entry;
+  }
 
-  /* If we are changing nickname of our local entry we'll enforce
-     that we will always get the unformatted nickname.  Give our
-     format number to the one that is not formatted now. */
-  if (unformatted && client_entry == conn->local_entry)
+  /* If priority formatting, this client always gets unformatted nickname. */
+  if (unformatted && priority)
     client_entry = unformatted;
 
   memset(newnick, 0, sizeof(newnick));
@@ -1027,7 +1153,7 @@ void silc_client_nickname_format(SilcClient client,
        }
 
        memset(tmp, 0, sizeof(tmp));
-       snprintf(tmp, sizeof(tmp) - 1, "%d", ++max);
+       silc_snprintf(tmp, sizeof(tmp) - 1, "%d", ++max);
        len = strlen(tmp);
        memcpy(&newnick[off], tmp, len);
        off += len;
@@ -1046,6 +1172,79 @@ void silc_client_nickname_format(SilcClient client,
   newnick[off] = 0;
   memcpy(client_entry->nickname, newnick, strlen(newnick));
   silc_client_list_free(client, conn, clients);
+
+  return client_entry;
+}
+
+/* Parses nickname according to nickname format string */
+
+SilcBool silc_client_nickname_parse(SilcClient client,
+                                   SilcClientConnection conn,
+                                   char *nickname,
+                                   char **ret_nick)
+{
+  char *cp, s = 0, e = 0, *nick;
+  SilcBool n = FALSE;
+  int len;
+
+  if (!client->internal->params->nickname_format[0])
+    return TRUE;
+
+  if (!nickname || !nickname[0])
+    return FALSE;
+
+  cp = client->internal->params->nickname_format;
+  while (cp && *cp) {
+    if (*cp == '%') {
+      cp++;
+      continue;
+    }
+
+    switch(*cp) {
+    case 'n':
+      n = TRUE;
+      break;
+
+    case 'h':
+    case 'H':
+    case 's':
+    case 'S':
+    case 'a':
+      break;
+
+    default:
+      /* Get separator character */
+      if (n)
+       e = *cp;
+      else
+       s = *cp;
+      break;
+    }
+
+     cp++;
+  }
+  if (!n)
+    return FALSE;
+
+  /* Parse the nickname */
+  nick = nickname;
+  len = strlen(nick);
+  if (s)
+    if (strchr(nickname, s))
+      nick = strchr(nickname, s) + 1;
+  if (e)
+    if (strchr(nick, e))
+      len = strchr(nick, e) - nick;
+  if (!len)
+    return FALSE;
+
+  *ret_nick = silc_memdup(nick, len);
+  if (!(*ret_nick))
+    return FALSE;
+
+  SILC_LOG_DEBUG(("Parsed nickname: %s", *ret_nick));
+
+  return TRUE;
 }
 
 /************************ Channel Searching Locally *************************/
@@ -1280,7 +1479,8 @@ SilcChannelEntry silc_client_add_channel(SilcClient client,
   if (!channel)
     return NULL;
 
-  silc_atomic_init8(&channel->internal.refcnt, 0);
+  silc_rwlock_alloc(&channel->internal.lock);
+  silc_atomic_init16(&channel->internal.refcnt, 0);
   channel->id = *channel_id;
   channel->mode = mode;
 
@@ -1324,7 +1524,7 @@ SilcChannelEntry silc_client_add_channel(SilcClient client,
   silc_mutex_unlock(conn->internal->lock);
   silc_client_ref_channel(client, conn, channel);
 
-  SILC_LOG_DEBUG(("Added"));
+  SILC_LOG_DEBUG(("Added %p", channel));
 
   return channel;
 }
@@ -1341,7 +1541,7 @@ SilcBool silc_client_del_channel(SilcClient client, SilcClientConnection conn,
   if (!channel)
     return FALSE;
 
-  if (silc_atomic_sub_int8(&channel->internal.refcnt, 1) > 0)
+  if (silc_atomic_sub_int16(&channel->internal.refcnt, 1) > 0)
     return FALSE;
 
   SILC_LOG_DEBUG(("Deleting channel %p", channel));
@@ -1360,8 +1560,10 @@ SilcBool silc_client_del_channel(SilcClient client, SilcClientConnection conn,
   silc_free(channel->topic);
   if (channel->founder_key)
     silc_pkcs_public_key_free(channel->founder_key);
-  if (channel->internal.channel_key)
-    silc_cipher_free(channel->internal.channel_key);
+  if (channel->internal.send_key)
+    silc_cipher_free(channel->internal.send_key);
+  if (channel->internal.receive_key)
+    silc_cipher_free(channel->internal.receive_key);
   if (channel->internal.hmac)
     silc_hmac_free(channel->internal.hmac);
   if (channel->internal.old_channel_keys) {
@@ -1376,8 +1578,12 @@ SilcBool silc_client_del_channel(SilcClient client, SilcClientConnection conn,
       silc_hmac_free(hmac);
     silc_dlist_uninit(channel->internal.old_hmacs);
   }
+  if (channel->channel_pubkeys)
+    silc_argument_list_free(channel->channel_pubkeys,
+                           SILC_ARGUMENT_PUBLIC_KEY);
   silc_client_del_channel_private_keys(client, conn, channel);
-  silc_atomic_uninit8(&channel->internal.refcnt);
+  silc_atomic_uninit16(&channel->internal.refcnt);
+  silc_rwlock_free(channel->internal.lock);
   silc_schedule_task_del_by_context(conn->client->schedule, channel);
   silc_free(channel);
 
@@ -1385,7 +1591,7 @@ SilcBool silc_client_del_channel(SilcClient client, SilcClientConnection conn,
 }
 
 /* Replaces the channel ID of the `channel' to `new_id'. Returns FALSE
-   if the ID could not be changed. */
+   if the ID could not be changed.  This handles entry locking internally. */
 
 SilcBool silc_client_replace_channel_id(SilcClient client,
                                        SilcClientConnection conn,
@@ -1403,23 +1609,41 @@ SilcBool silc_client_replace_channel_id(SilcClient client,
                  silc_id_render(new_id, SILC_ID_CHANNEL)));
 
   /* Update the ID */
+  silc_rwlock_wrlock(channel->internal.lock);
   silc_mutex_lock(conn->internal->lock);
   silc_idcache_update_by_context(conn->internal->channel_cache, channel,
                                 new_id, NULL, FALSE);
   silc_mutex_unlock(conn->internal->lock);
+  silc_rwlock_unlock(channel->internal.lock);
 
   return ret;
 }
 
+/* Lock channel */
+
+void silc_client_lock_channel(SilcChannelEntry channel_entry)
+{
+  silc_rwlock_rdlock(channel_entry->internal.lock);
+}
+
+/* Unlock client */
+
+void silc_client_unlock_channel(SilcChannelEntry channel_entry)
+{
+  silc_rwlock_unlock(channel_entry->internal.lock);
+}
+
 /* Take reference of channel entry */
 
-void silc_client_ref_channel(SilcClient client, SilcClientConnection conn,
-                            SilcChannelEntry channel_entry)
+SilcChannelEntry silc_client_ref_channel(SilcClient client,
+                                        SilcClientConnection conn,
+                                        SilcChannelEntry channel_entry)
 {
-  silc_atomic_add_int8(&channel_entry->internal.refcnt, 1);
+  silc_atomic_add_int16(&channel_entry->internal.refcnt, 1);
   SILC_LOG_DEBUG(("Channel %p refcnt %d->%d", channel_entry,
-                 silc_atomic_get_int8(&channel_entry->internal.refcnt) - 1,
-                 silc_atomic_get_int8(&channel_entry->internal.refcnt)));
+                 silc_atomic_get_int16(&channel_entry->internal.refcnt) - 1,
+                 silc_atomic_get_int16(&channel_entry->internal.refcnt)));
+  return channel_entry;
 }
 
 /* Release reference of channel entry */
@@ -1429,8 +1653,8 @@ void silc_client_unref_channel(SilcClient client, SilcClientConnection conn,
 {
   if (channel_entry) {
     SILC_LOG_DEBUG(("Channel %p refcnt %d->%d", channel_entry,
-                   silc_atomic_get_int8(&channel_entry->internal.refcnt),
-                   silc_atomic_get_int8(&channel_entry->internal.refcnt)
+                   silc_atomic_get_int16(&channel_entry->internal.refcnt),
+                   silc_atomic_get_int16(&channel_entry->internal.refcnt)
                    - 1));
     silc_client_del_channel(client, conn, channel_entry);
   }
@@ -1667,6 +1891,7 @@ SilcServerEntry silc_client_add_server(SilcClient client,
   if (!server_entry)
     return NULL;
 
+  silc_rwlock_alloc(&server_entry->internal.lock);
   silc_atomic_init8(&server_entry->internal.refcnt, 0);
   server_entry->id = *server_id;
   if (server_name)
@@ -1702,7 +1927,7 @@ SilcServerEntry silc_client_add_server(SilcClient client,
   silc_mutex_unlock(conn->internal->lock);
   silc_client_ref_server(client, conn, server_entry);
 
-  SILC_LOG_DEBUG(("Added"));
+  SILC_LOG_DEBUG(("Added %p", server_entry));
 
   return server_entry;
 }
@@ -1732,6 +1957,7 @@ SilcBool silc_client_del_server(SilcClient client, SilcClientConnection conn,
   if (server->public_key)
     silc_pkcs_public_key_free(server->public_key);
   silc_atomic_uninit8(&server->internal.refcnt);
+  silc_rwlock_free(server->internal.lock);
   silc_free(server);
 
   return ret;
@@ -1778,12 +2004,31 @@ void silc_client_update_server(SilcClient client,
   }
 }
 
+/* Lock server */
+
+void silc_client_lock_server(SilcServerEntry server_entry)
+{
+  silc_rwlock_rdlock(server_entry->internal.lock);
+}
+
+/* Unlock server */
+
+void silc_client_unlock_server(SilcServerEntry server_entry)
+{
+  silc_rwlock_unlock(server_entry->internal.lock);
+}
+
 /* Take reference of server entry */
 
-void silc_client_ref_server(SilcClient client, SilcClientConnection conn,
-                           SilcServerEntry server_entry)
+SilcServerEntry silc_client_ref_server(SilcClient client,
+                                      SilcClientConnection conn,
+                                      SilcServerEntry server_entry)
 {
   silc_atomic_add_int8(&server_entry->internal.refcnt, 1);
+  SILC_LOG_DEBUG(("Server %p refcnt %d->%d", server_entry,
+                 silc_atomic_get_int8(&server_entry->internal.refcnt) - 1,
+                 silc_atomic_get_int8(&server_entry->internal.refcnt)));
+  return server_entry;
 }
 
 /* Release reference of server entry */
@@ -1791,7 +2036,13 @@ void silc_client_ref_server(SilcClient client, SilcClientConnection conn,
 void silc_client_unref_server(SilcClient client, SilcClientConnection conn,
                              SilcServerEntry server_entry)
 {
-  silc_client_del_server(client, conn, server_entry);
+  if (server_entry) {
+    SILC_LOG_DEBUG(("Server %p refcnt %d->%d", server_entry,
+                   silc_atomic_get_int8(&server_entry->internal.refcnt),
+                   silc_atomic_get_int8(&server_entry->internal.refcnt)
+                   - 1));
+    silc_client_del_server(client, conn, server_entry);
+  }
 }
 
 /* Free server entry list */