Fixed UDP transport handling.
[silc.git] / lib / silccore / silcpacket.c
index 2a2b9af18345a2079f7403b83c25dc48cd5c1b05..e2bf31258f997f8cfe85df825dba98a6e1d59c0e 100644 (file)
@@ -33,10 +33,11 @@ struct SilcPacketEngineStruct {
   SilcList streams;                     /* All streams in engine */
   SilcList packet_pool;                 /* Free list for received packets */
   SilcMutex lock;                       /* Engine lock */
+  SilcHashTable udp_remote;             /* UDP remote streams, or NULL */
   SilcBool local_is_router;
 };
 
-/* Packet procesor context */
+/* Packet processor context */
 typedef struct SilcPacketProcessStruct {
   SilcInt32 priority;                   /* Priority */
   SilcPacketType *types;                /* Packets to process */
@@ -44,13 +45,20 @@ typedef struct SilcPacketProcessStruct {
   void *callback_context;
 } *SilcPacketProcess;
 
+/* UDP remote stream tuple */
+typedef struct {
+  char *remote_ip;                      /* Remote IP address */
+  SilcUInt16 remote_port;               /* Remote port */
+} *SilcPacketRemoteUDP;
+
 /* Packet stream */
 struct SilcPacketStreamStruct {
   struct SilcPacketStreamStruct *next;
   SilcPacketEngine engine;              /* Packet engine */
   SilcStream stream;                    /* Underlaying stream */
   SilcMutex lock;                       /* Stream lock */
-  SilcDList process;                    /* Packet processors, it set */
+  SilcDList process;                    /* Packet processors, or NULL */
+  SilcPacketRemoteUDP remote_udp;       /* UDP remote stream tuple, or NULL */
   void *stream_context;                         /* Stream context */
   SilcBufferStruct inbuf;               /* In buffer */
   SilcBufferStruct outbuf;              /* Out buffer */
@@ -63,6 +71,7 @@ struct SilcPacketStreamStruct {
   SilcUInt32 send_psn;                  /* Sending sequence */
   SilcUInt32 receive_psn;               /* Receiving sequence */
   SilcAtomic8 refcnt;                   /* Reference counter */
+  SilcUInt8 sid;                        /* Security ID, set if IV included */
   unsigned int src_id_len  : 6;
   unsigned int src_id_type : 2;
   unsigned int dst_id_len  : 6;
@@ -70,7 +79,7 @@ struct SilcPacketStreamStruct {
   unsigned int is_router   : 1;                 /* Set if router stream */
   unsigned int destroyed   : 1;                 /* Set if destroyed */
   unsigned int iv_included : 1;          /* Set if IV included */
-  SilcUInt8 sid;                        /* Security ID, set if IV included */
+  unsigned int udp         : 1;          /* UDP remote stream */
 };
 
 /* Initial size of stream buffers */
@@ -142,114 +151,280 @@ do {                                                                    \
                                (s)->stream_context);                   \
 } while(0)
 
+static void silc_packet_dispatch(SilcPacket packet);
+static void silc_packet_read_process(SilcPacketStream stream);
 
 /************************ Static utility functions **************************/
 
-static void silc_packet_read_process(SilcPacketStream stream);
+/* Injects packet to new stream created with silc_packet_stream_add_remote. */
 
-/* Our stream IO notifier callback. */
+SILC_TASK_CALLBACK(silc_packet_stream_inject_packet)
+{
+  SilcPacket packet = context;
+  SilcPacketStream stream = packet->stream;
 
-static void silc_packet_stream_io(SilcStream stream, SilcStreamStatus status,
-                                 void *context)
+  SILC_LOG_DEBUG(("Injecting packet %p to stream %p", packet, packet->stream));
+
+  silc_mutex_lock(stream->lock);
+  silc_packet_dispatch(packet);
+  silc_mutex_unlock(stream->lock);
+}
+
+/* Write data to the stream.  Must be called with ps->lock locked.  Unlocks
+   the lock inside this function. */
+
+static inline SilcBool silc_packet_stream_write(SilcPacketStream ps)
 {
-  SilcPacketStream ps = context;
-  int ret;
+  SilcStream stream;
+  SilcBool connected;
+  int i;
 
-  silc_mutex_lock(ps->lock);
+  if (ps->udp)
+    stream = ((SilcPacketStream)ps->stream)->stream;
+  else
+    stream = ps->stream;
+
+  if (ps->udp && silc_socket_stream_is_udp(stream, &connected)) {
+    if (!connected) {
+      /* Connectionless UDP stream */
+      while (silc_buffer_len(&ps->outbuf) > 0) {
+       i = silc_net_udp_send(stream, ps->remote_udp->remote_ip,
+                             ps->remote_udp->remote_port,
+                             ps->outbuf.data, silc_buffer_len(&ps->outbuf));
+       if (i == -2) {
+         /* Error */
+         silc_buffer_reset(&ps->outbuf);
+         silc_mutex_unlock(ps->lock);
+         SILC_PACKET_CALLBACK_ERROR(ps, SILC_PACKET_ERR_WRITE);
+         return FALSE;
+       }
 
-  if (ps->destroyed) {
-    silc_mutex_unlock(ps->lock);
-    return;
+       if (i == -1) {
+         /* Cannot write now, write later. */
+         silc_mutex_unlock(ps->lock);
+         return TRUE;
+       }
+
+       /* Wrote data */
+       silc_buffer_pull(&ps->outbuf, i);
+      }
+
+      silc_buffer_reset(&ps->outbuf);
+      silc_mutex_unlock(ps->lock);
+
+      return TRUE;
+    }
   }
 
-  switch (status) {
+  /* Write the data to the stream */
+  while (silc_buffer_len(&ps->outbuf) > 0) {
+    i = silc_stream_write(stream, ps->outbuf.data,
+                         silc_buffer_len(&ps->outbuf));
+    if (i == 0) {
+      /* EOS */
+      silc_buffer_reset(&ps->outbuf);
+      silc_mutex_unlock(ps->lock);
+      SILC_PACKET_CALLBACK_EOS(ps);
+      return FALSE;
+    }
 
-  case SILC_STREAM_CAN_WRITE:
-    if (!silc_buffer_headlen(&ps->outbuf)) {
+    if (i == -2) {
+      /* Error */
+      silc_buffer_reset(&ps->outbuf);
       silc_mutex_unlock(ps->lock);
-      return;
+      SILC_PACKET_CALLBACK_ERROR(ps, SILC_PACKET_ERR_WRITE);
+      return FALSE;
     }
 
-    SILC_LOG_DEBUG(("Writing pending data to stream"));
+    if (i == -1) {
+      /* Cannot write now, write later. */
+      silc_mutex_unlock(ps->lock);
+      return TRUE;
+    }
 
-    /* Write pending data to stream */
-    while (silc_buffer_len(&ps->outbuf) > 0) {
-      ret = silc_stream_write(ps->stream, ps->outbuf.data,
-                             silc_buffer_len(&ps->outbuf));
-      if (ret == 0) {
-       /* EOS */
-       silc_buffer_reset(&ps->outbuf);
-       silc_mutex_unlock(ps->lock);
-       SILC_PACKET_CALLBACK_EOS(ps);
-       return;
-      }
+    /* Wrote data */
+    silc_buffer_pull(&ps->outbuf, i);
+  }
+
+  silc_buffer_reset(&ps->outbuf);
+  silc_mutex_unlock(ps->lock);
+
+  return TRUE;
+}
+
+/* Reads data from stream.  Must be called with the ps->lock locked.  If this
+   returns FALSE the lock has been unlocked.  If this returns packet stream
+   to `ret_ps' its lock has been acquired and `ps' lock has been unlocked.
+   It is returned if the stream is UDP and remote UDP stream exists for
+   the sender of the packet. */
+
+static inline SilcBool silc_packet_stream_read(SilcPacketStream ps,
+                                              SilcPacketStream *ret_ps)
+{
+  SilcStream stream;
+  SilcBool connected;
+  int ret;
+
+  stream = ps->stream;
 
+  /* Make sure we have fair amount of free space in inbuf */
+  if (silc_buffer_taillen(&ps->inbuf) < SILC_PACKET_DEFAULT_SIZE)
+    if (!silc_buffer_realloc(&ps->inbuf, silc_buffer_truelen(&ps->inbuf) +
+                            SILC_PACKET_DEFAULT_SIZE * 2)) {
+      silc_mutex_unlock(ps->lock);
+      SILC_PACKET_CALLBACK_ERROR(ps, SILC_PACKET_ERR_NO_MEMORY);
+      return FALSE;
+    }
+
+  if (silc_socket_stream_is_udp(stream, &connected)) {
+    if (!connected) {
+      /* Connectionless UDP stream, read one UDP packet */
+      char remote_ip[64], tuple[64];
+      int remote_port;
+      SilcPacketStream remote;
+
+      ret = silc_net_udp_receive(stream, remote_ip, sizeof(remote_ip),
+                                &remote_port, ps->inbuf.tail,
+                                silc_buffer_taillen(&ps->inbuf));
       if (ret == -2) {
        /* Error */
-       silc_buffer_reset(&ps->outbuf);
+       silc_buffer_reset(&ps->inbuf);
        silc_mutex_unlock(ps->lock);
-       SILC_PACKET_CALLBACK_ERROR(ps, SILC_PACKET_ERR_WRITE);
-       return;
+       SILC_PACKET_CALLBACK_ERROR(ps, SILC_PACKET_ERR_READ);
+       return FALSE;
       }
 
       if (ret == -1) {
-       /* Cannot write now, write later. */
+       /* Cannot read now, do it later. */
+       silc_buffer_pull(&ps->inbuf, silc_buffer_len(&ps->inbuf));
        silc_mutex_unlock(ps->lock);
-       return;
+       return FALSE;
       }
 
-      /* Wrote data */
-      silc_buffer_pull(&ps->outbuf, ret);
+      /* See if remote packet stream exist for this sender */
+      snprintf(tuple, sizeof(tuple), "%d%s", remote_port, remote_ip);
+      silc_mutex_lock(ps->engine->lock);
+      if (silc_hash_table_find(ps->engine->udp_remote, tuple, NULL,
+                              (void *)&remote)) {
+       /* Found packet stream for this sender, copy the packet */
+       silc_mutex_unlock(ps->engine->lock);
+
+       SILC_LOG_DEBUG(("UDP packet from %s:%d for stream %p",
+                       remote_ip, remote_port, remote));
+
+       silc_mutex_lock(remote->lock);
+       if (ret > silc_buffer_taillen(&remote->inbuf))
+         if (!silc_buffer_realloc(&remote->inbuf, ret)) {
+           silc_mutex_unlock(remote->lock);
+           silc_mutex_unlock(ps->lock);
+           SILC_PACKET_CALLBACK_ERROR(ps, SILC_PACKET_ERR_NO_MEMORY);
+           return FALSE;
+         }
+
+       silc_buffer_put_tail(&remote->inbuf, ps->inbuf.tail, ret);
+       silc_buffer_pull_tail(&remote->inbuf, ret);
+       *ret_ps = remote;
+
+       silc_buffer_reset(&ps->inbuf);
+       silc_mutex_unlock(ps->lock);
+       return TRUE;
+      }
+      silc_mutex_unlock(ps->engine->lock);
+
+      /* Unknown sender */
+      if (!ps->remote_udp) {
+       ps->remote_udp = silc_calloc(1, sizeof(*ps->remote_udp));
+       if (!ps->remote_udp) {
+         silc_mutex_unlock(ps->lock);
+         SILC_PACKET_CALLBACK_ERROR(ps, SILC_PACKET_ERR_NO_MEMORY);
+         return FALSE;
+       }
+      }
+
+      /* Save sender IP and port */
+      silc_free(ps->remote_udp->remote_ip);
+      ps->remote_udp->remote_ip = strdup(remote_ip);
+      ps->remote_udp->remote_port = remote_port;
+
+      silc_buffer_pull_tail(&ps->inbuf, ret);
+      return TRUE;
     }
+  }
 
-    silc_buffer_reset(&ps->outbuf);
+  /* Read data from the stream */
+  ret = silc_stream_read(ps->stream, ps->inbuf.tail,
+                        silc_buffer_taillen(&ps->inbuf));
 
+  if (ret == 0) {
+    /* EOS */
+    silc_buffer_reset(&ps->inbuf);
     silc_mutex_unlock(ps->lock);
-    break;
+    SILC_PACKET_CALLBACK_EOS(ps);
+    return FALSE;
+  }
 
-  case SILC_STREAM_CAN_READ:
-    SILC_LOG_DEBUG(("Reading data from stream"));
+  if (ret == -2) {
+    /* Error */
+    silc_buffer_reset(&ps->inbuf);
+    silc_mutex_unlock(ps->lock);
+    SILC_PACKET_CALLBACK_ERROR(ps, SILC_PACKET_ERR_READ);
+    return FALSE;
+  }
 
-    /* Make sure we have fair amount of free space in inbuf */
-    if (silc_buffer_taillen(&ps->inbuf) < SILC_PACKET_DEFAULT_SIZE)
-      if (!silc_buffer_realloc(&ps->inbuf, silc_buffer_truelen(&ps->inbuf) +
-                              SILC_PACKET_DEFAULT_SIZE * 2)) {
-       silc_mutex_unlock(ps->lock);
-       return;
-      }
+  if (ret == -1) {
+    /* Cannot read now, do it later. */
+    silc_buffer_pull(&ps->inbuf, silc_buffer_len(&ps->inbuf));
+    silc_mutex_unlock(ps->lock);
+    return FALSE;
+  }
 
-    /* Read data from stream */
-    ret = silc_stream_read(ps->stream, ps->inbuf.tail,
-                          silc_buffer_taillen(&ps->inbuf));
+  silc_buffer_pull_tail(&ps->inbuf, ret);
+  return TRUE;
+}
 
-    if (ret == 0) {
-      /* EOS */
-      silc_buffer_reset(&ps->inbuf);
-      silc_mutex_unlock(ps->lock);
-      SILC_PACKET_CALLBACK_EOS(ps);
-      return;
-    }
+/* Our stream IO notifier callback. */
 
-    if (ret == -2) {
-      /* Error */
-      silc_buffer_reset(&ps->inbuf);
+static void silc_packet_stream_io(SilcStream stream, SilcStreamStatus status,
+                                 void *context)
+{
+  SilcPacketStream remote = NULL, ps = context;
+
+  silc_mutex_lock(ps->lock);
+
+  if (ps->destroyed) {
+    silc_mutex_unlock(ps->lock);
+    return;
+  }
+
+  switch (status) {
+
+  case SILC_STREAM_CAN_WRITE:
+    SILC_LOG_DEBUG(("Writing pending data to stream"));
+
+    if (!silc_buffer_headlen(&ps->outbuf)) {
       silc_mutex_unlock(ps->lock);
-      SILC_PACKET_CALLBACK_ERROR(ps, SILC_PACKET_ERR_READ);
       return;
     }
 
-    if (ret == -1) {
-      /* Cannot read now, do it later. */
-      silc_buffer_pull(&ps->inbuf, silc_buffer_len(&ps->inbuf));
-      silc_mutex_unlock(ps->lock);
+    /* Write pending data to stream */
+    silc_packet_stream_write(ps);
+    break;
+
+  case SILC_STREAM_CAN_READ:
+    SILC_LOG_DEBUG(("Reading data from stream"));
+
+    /* Read data from stream */
+    if (!silc_packet_stream_read(ps, &remote))
       return;
-    }
 
     /* Now process the data */
-    silc_buffer_pull_tail(&ps->inbuf, ret);
-    silc_packet_read_process(ps);
-
-    silc_mutex_unlock(ps->lock);
+    if (!remote) {
+      silc_packet_read_process(ps);
+      silc_mutex_unlock(ps->lock);
+    } else {
+      silc_packet_read_process(remote);
+      silc_mutex_unlock(remote->lock);
+    }
     break;
 
   default:
@@ -303,6 +478,14 @@ static SilcPacket silc_packet_alloc(SilcPacketEngine engine)
   return packet;
 }
 
+/* UDP remote stream hash table destructor */
+
+static void silc_packet_engine_hash_destr(void *key, void *context,
+                                         void *user_context)
+{
+  silc_free(key);
+}
+
 
 /******************************** Packet API ********************************/
 
@@ -340,12 +523,16 @@ silc_packet_engine_start(SilcRng rng, SilcBool router,
   silc_list_init(engine->packet_pool, struct SilcPacketStruct, next);
   for (i = 0; i < 5; i++) {
     packet = silc_calloc(1, sizeof(*packet));
-    if (!packet)
+    if (!packet) {
+      silc_packet_engine_stop(engine);
       return NULL;
+    }
 
     tmp = silc_malloc(SILC_PACKET_DEFAULT_SIZE);
-    if (!tmp)
+    if (!tmp) {
+      silc_packet_engine_stop(engine);
       return NULL;
+    }
     silc_buffer_set(&packet->buffer, tmp, SILC_PACKET_DEFAULT_SIZE);
     silc_buffer_reset(&packet->buffer);
 
@@ -392,32 +579,139 @@ SilcPacketStream silc_packet_stream_create(SilcPacketEngine engine,
   ps->engine = engine;
   ps->stream = stream;
   silc_atomic_init8(&ps->refcnt, 1);
+  silc_mutex_alloc(&ps->lock);
 
   /* Allocate buffers */
   tmp = silc_malloc(SILC_PACKET_DEFAULT_SIZE);
-  if (!tmp)
+  if (!tmp) {
+    silc_packet_stream_destroy(ps);
     return NULL;
+  }
   silc_buffer_set(&ps->inbuf, tmp, SILC_PACKET_DEFAULT_SIZE);
   silc_buffer_reset(&ps->inbuf);
   tmp = silc_malloc(SILC_PACKET_DEFAULT_SIZE);
-  if (!tmp)
+  if (!tmp) {
+    silc_packet_stream_destroy(ps);
     return NULL;
+  }
   silc_buffer_set(&ps->outbuf, tmp, SILC_PACKET_DEFAULT_SIZE);
   silc_buffer_reset(&ps->outbuf);
 
   /* Initialize packet procesors list */
   ps->process = silc_dlist_init();
+  if (!ps->process) {
+    silc_packet_stream_destroy(ps);
+    return NULL;
+  }
 
   /* Set IO notifier callback */
   silc_stream_set_notifier(ps->stream, schedule, silc_packet_stream_io, ps);
 
-  silc_mutex_alloc(&ps->lock);
-
   /* Add to engine */
   silc_mutex_lock(engine->lock);
   silc_list_add(engine->streams, ps);
   silc_mutex_unlock(engine->lock);
 
+  /* If this is UDP stream, allocate UDP remote stream hash table */
+  if (!engine->udp_remote && silc_socket_stream_is_udp(stream, NULL))
+    engine->udp_remote = silc_hash_table_alloc(0, silc_hash_string, NULL,
+                                              silc_hash_string_compare, NULL,
+                                              silc_packet_engine_hash_destr,
+                                              NULL, TRUE);
+
+  return ps;
+}
+
+/* Add new remote packet stream for UDP packet streams */
+
+SilcPacketStream silc_packet_stream_add_remote(SilcPacketStream stream,
+                                              const char *remote_ip,
+                                              SilcUInt16 remote_port,
+                                              SilcPacket packet)
+{
+  SilcPacketEngine engine = stream->engine;
+  SilcPacketStream ps;
+  char *tuple;
+  void *tmp;
+
+  SILC_LOG_DEBUG(("Adding UDP remote %s:%d to packet stream %p",
+                 remote_ip, remote_port, stream));
+
+  if (!stream || !remote_ip || !remote_port)
+    return NULL;
+
+  if (!silc_socket_stream_is_udp(stream->stream, NULL)) {
+    SILC_LOG_ERROR(("Stream is not UDP stream, cannot add remote IP"));
+    return NULL;
+  }
+
+  ps = silc_calloc(1, sizeof(*ps));
+  if (!ps)
+    return NULL;
+
+  ps->engine = engine;
+  silc_atomic_init8(&ps->refcnt, 1);
+  silc_mutex_alloc(&ps->lock);
+
+  /* Set the UDP packet stream as underlaying stream */
+  silc_packet_stream_ref(stream);
+  ps->stream = (SilcStream)stream;
+  ps->udp = TRUE;
+
+  /* Allocate buffers */
+  tmp = silc_malloc(SILC_PACKET_DEFAULT_SIZE);
+  if (!tmp) {
+    silc_packet_stream_destroy(ps);
+    return NULL;
+  }
+  silc_buffer_set(&ps->inbuf, tmp, SILC_PACKET_DEFAULT_SIZE);
+  silc_buffer_reset(&ps->inbuf);
+  tmp = silc_malloc(SILC_PACKET_DEFAULT_SIZE);
+  if (!tmp) {
+    silc_packet_stream_destroy(ps);
+    return NULL;
+  }
+  silc_buffer_set(&ps->outbuf, tmp, SILC_PACKET_DEFAULT_SIZE);
+  silc_buffer_reset(&ps->outbuf);
+
+  /* Initialize packet procesors list */
+  ps->process = silc_dlist_init();
+  if (!ps->process) {
+    silc_packet_stream_destroy(ps);
+    return NULL;
+  }
+
+  /* Add to engine with this IP and port pair */
+  tuple = silc_format("%d%s", remote_port, remote_ip);
+  silc_mutex_lock(engine->lock);
+  if (!tuple || !silc_hash_table_add(engine->udp_remote, tuple, ps)) {
+    silc_mutex_unlock(engine->lock);
+    silc_packet_stream_destroy(ps);
+    return NULL;
+  }
+  silc_mutex_unlock(engine->lock);
+
+  /* Save remote IP and port pair */
+  ps->remote_udp = silc_calloc(1, sizeof(*ps->remote_udp));
+  if (!ps->remote_udp) {
+    silc_packet_stream_destroy(ps);
+    return NULL;
+  }
+  ps->remote_udp->remote_port = remote_port;
+  ps->remote_udp->remote_ip = strdup(remote_ip);
+  if (!ps->remote_udp->remote_ip) {
+    silc_packet_stream_destroy(ps);
+    return NULL;
+  }
+
+  if (packet) {
+    /* Inject packet to the new stream */
+    packet->stream = ps;
+    silc_schedule_task_add_timeout(silc_stream_get_schedule(stream->stream),
+                                  silc_packet_stream_inject_packet, packet,
+                                  0, 0);
+  }
+
   return ps;
 }
 
@@ -435,10 +729,30 @@ void silc_packet_stream_destroy(SilcPacketStream stream)
 
   SILC_LOG_DEBUG(("Destroying packet stream %p", stream));
 
-  /* Delete from engine */
-  silc_mutex_lock(stream->engine->lock);
-  silc_list_del(stream->engine->streams, stream);
-  silc_mutex_unlock(stream->engine->lock);
+  if (!stream->udp) {
+    /* Delete from engine */
+    silc_mutex_lock(stream->engine->lock);
+    silc_list_del(stream->engine->streams, stream);
+    silc_mutex_unlock(stream->engine->lock);
+
+    /* Destroy the underlaying stream */
+    if (stream->stream)
+      silc_stream_destroy(stream->stream);
+  } else {
+    /* Delete from UDP remote hash table */
+    char tuple[64];
+    snprintf(tuple, sizeof(tuple), "%d%s", stream->remote_udp->remote_port,
+            stream->remote_udp->remote_ip);
+    silc_mutex_lock(stream->engine->lock);
+    silc_hash_table_del(stream->engine->udp_remote, tuple);
+    silc_mutex_unlock(stream->engine->lock);
+
+    silc_free(stream->remote_udp->remote_ip);
+    silc_free(stream->remote_udp);
+
+    /* Unreference the underlaying packet stream */
+    silc_packet_stream_unref((SilcPacketStream)stream->stream);
+  }
 
   /* Clear and free buffers */
   silc_buffer_clear(&stream->inbuf);
@@ -448,9 +762,6 @@ void silc_packet_stream_destroy(SilcPacketStream stream)
 
   /* XXX */
 
-  /* Destroy the underlaying stream */
-  silc_stream_destroy(stream->stream);
-
   silc_atomic_uninit8(&stream->refcnt);
   silc_dlist_uninit(stream->process);
   silc_mutex_free(stream->lock);
@@ -599,6 +910,21 @@ void silc_packet_stream_unlink(SilcPacketStream stream,
   silc_packet_stream_unref(stream);
 }
 
+/* Return packet sender IP and port for UDP packet stream */
+
+SilcBool silc_packet_get_sender(SilcPacket packet,
+                               const char **sender_ip,
+                               SilcUInt16 *sender_port)
+{
+  if (!packet->stream->remote_udp)
+    return FALSE;
+
+  *sender_ip = packet->stream->remote_udp->remote_ip;
+  *sender_port = packet->stream->remote_udp->remote_port;
+
+  return TRUE;
+}
+
 /* Reference packet stream */
 
 void silc_packet_stream_ref(SilcPacketStream stream)
@@ -1023,38 +1349,7 @@ static SilcBool silc_packet_send_raw(SilcPacketStream stream,
   }
 
   /* Write the packet to the stream */
-  while (silc_buffer_len(&stream->outbuf) > 0) {
-    i = silc_stream_write(stream->stream, stream->outbuf.data,
-                         silc_buffer_len(&stream->outbuf));
-    if (i == 0) {
-      /* EOS */
-      silc_buffer_reset(&stream->outbuf);
-      silc_mutex_unlock(stream->lock);
-      SILC_PACKET_CALLBACK_EOS(stream);
-      return FALSE;
-    }
-
-    if (i == -2) {
-      /* Error */
-      silc_buffer_reset(&stream->outbuf);
-      silc_mutex_unlock(stream->lock);
-      SILC_PACKET_CALLBACK_ERROR(stream, SILC_PACKET_ERR_WRITE);
-      return FALSE;
-    }
-
-    if (i == -1) {
-      /* Cannot write now, write later. */
-      silc_mutex_unlock(stream->lock);
-      return TRUE;
-    }
-
-    /* Wrote data */
-    silc_buffer_pull(&stream->outbuf, i);
-  }
-  silc_buffer_reset(&stream->outbuf);
-
-  silc_mutex_unlock(stream->lock);
-  return TRUE;
+  return silc_packet_stream_write(stream);
 }
 
 /* Sends a packet */
@@ -1168,12 +1463,12 @@ SilcBool silc_packet_send_va_ext(SilcPacketStream stream,
 
 /* Checks MAC in the packet. Returns TRUE if MAC is Ok. */
 
-static SilcBool silc_packet_check_mac(SilcHmac hmac,
-                                     const unsigned char *data,
-                                     SilcUInt32 data_len,
-                                     const unsigned char *packet_mac,
-                                     const unsigned char *packet_seq,
-                                     SilcUInt32 sequence)
+static inline SilcBool silc_packet_check_mac(SilcHmac hmac,
+                                            const unsigned char *data,
+                                            SilcUInt32 data_len,
+                                            const unsigned char *packet_mac,
+                                            const unsigned char *packet_seq,
+                                            SilcUInt32 sequence)
 {
   /* Check MAC */
   if (hmac) {
@@ -1209,9 +1504,9 @@ static SilcBool silc_packet_check_mac(SilcHmac hmac,
 /* Decrypts SILC packet.  Handles both normal and special packet decryption.
    Return 0 when packet is normal and 1 when it it special, -1 on error. */
 
-static int silc_packet_decrypt(SilcCipher cipher, SilcHmac hmac,
-                              SilcUInt32 sequence, SilcBuffer buffer,
-                              SilcBool normal)
+static inline int silc_packet_decrypt(SilcCipher cipher, SilcHmac hmac,
+                                     SilcUInt32 sequence, SilcBuffer buffer,
+                                     SilcBool normal)
 {
   if (normal == TRUE) {
     if (cipher) {
@@ -1257,7 +1552,7 @@ static int silc_packet_decrypt(SilcCipher cipher, SilcHmac hmac,
    parsed. The buffer sent must be already decrypted before calling this
    function. */
 
-static SilcBool silc_packet_parse(SilcPacket packet)
+static inline SilcBool silc_packet_parse(SilcPacket packet)
 {
   SilcBuffer buffer = &packet->buffer;
   SilcUInt8 padlen = (SilcUInt8)buffer->data[4];
@@ -1275,14 +1570,18 @@ static SilcBool silc_packet_parse(SilcPacket packet)
                             SILC_STR_UI_CHAR(&src_id_type),
                             SILC_STR_END);
   if (ret == -1) {
-    SILC_LOG_ERROR(("Malformed packet header, packet dropped"));
+    if (!packet->stream->udp &&
+       !silc_socket_stream_is_udp(packet->stream->stream, NULL))
+      SILC_LOG_ERROR(("Malformed packet header, packet dropped"));
     return FALSE;
   }
 
   if (src_id_len > SILC_PACKET_MAX_ID_LEN ||
       dst_id_len > SILC_PACKET_MAX_ID_LEN) {
-    SILC_LOG_ERROR(("Bad ID lengths in packet (%d and %d)",
-                   packet->src_id_len, packet->dst_id_len));
+    if (!packet->stream->udp &&
+       !silc_socket_stream_is_udp(packet->stream->stream, NULL))
+      SILC_LOG_ERROR(("Bad ID lengths in packet (%d and %d)",
+                     packet->src_id_len, packet->dst_id_len));
     return FALSE;
   }
 
@@ -1294,14 +1593,18 @@ static SilcBool silc_packet_parse(SilcPacket packet)
                             SILC_STR_OFFSET(padlen),
                             SILC_STR_END);
   if (ret == -1) {
-    SILC_LOG_ERROR(("Malformed packet header, packet dropped"));
+    if (!packet->stream->udp &&
+       !silc_socket_stream_is_udp(packet->stream->stream, NULL))
+      SILC_LOG_ERROR(("Malformed packet header, packet dropped"));
     return FALSE;
   }
 
   if (src_id_type > SILC_ID_CHANNEL ||
       dst_id_type > SILC_ID_CHANNEL) {
-    SILC_LOG_ERROR(("Bad ID types in packet (%d and %d)",
-                   src_id_type, dst_id_type));
+    if (!packet->stream->udp &&
+       !silc_socket_stream_is_udp(packet->stream->stream, NULL))
+      SILC_LOG_ERROR(("Bad ID types in packet (%d and %d)",
+                     src_id_type, dst_id_type));
     return FALSE;
   }
 
@@ -1329,15 +1632,6 @@ static void silc_packet_dispatch(SilcPacket packet)
   SilcBool default_sent = FALSE;
   SilcPacketType *pt;
 
-  /* Parse the packet */
-  if (!silc_packet_parse(packet)) {
-    silc_mutex_unlock(stream->lock);
-    SILC_PACKET_CALLBACK_ERROR(stream, SILC_PACKET_ERR_MALFORMED);
-    silc_mutex_lock(stream->lock);
-    silc_packet_free(packet);
-    return;
-  }
-
   /* Dispatch packet to all packet processors that want it */
 
   if (!stream->process) {
@@ -1434,7 +1728,7 @@ static void silc_packet_read_process(SilcPacketStream stream)
   SilcUInt32 paddedlen, mac_len, block_len, ivlen, psnlen;
   unsigned char tmp[SILC_PACKET_MIN_HEADER_LEN], *header;
   unsigned char iv[SILC_CIPHER_MAX_IV_SIZE], *packet_seq = NULL;
-  SilcBool normal = TRUE;
+  SilcBool normal;
   int ret;
 
   /* Parse the packets from the data */
@@ -1442,6 +1736,7 @@ static void silc_packet_read_process(SilcPacketStream stream)
     ivlen = psnlen = 0;
     cipher = stream->receive_key[0];
     hmac = stream->receive_hmac[0];
+    normal = FALSE;
 
     if (silc_buffer_len(&stream->inbuf) <
        (stream->iv_included ? SILC_PACKET_MIN_HEADER_LEN_IV :
@@ -1507,7 +1802,8 @@ static void silc_packet_read_process(SilcPacketStream stream)
 
     /* Sanity checks */
     if (packetlen < SILC_PACKET_MIN_LEN) {
-      SILC_LOG_ERROR(("Received too short packet"));
+      if (!stream->udp && !silc_socket_stream_is_udp(stream->stream, NULL))
+       SILC_LOG_ERROR(("Received too short packet"));
       silc_mutex_unlock(stream->lock);
       SILC_PACKET_CALLBACK_ERROR(stream, SILC_PACKET_ERR_MALFORMED);
       silc_mutex_lock(stream->lock);
@@ -1547,6 +1843,7 @@ static void silc_packet_read_process(SilcPacketStream stream)
       silc_buffer_reset(&stream->inbuf);
       return;
     }
+    packet->stream = stream;
 
     /* Allocate more space to packet buffer, if needed */
     if (silc_buffer_truelen(&packet->buffer) < paddedlen) {
@@ -1615,8 +1912,17 @@ static void silc_packet_read_process(SilcPacketStream stream)
     /* Pull the packet from inbuf thus we'll get the next one in the inbuf. */
     silc_buffer_pull(&stream->inbuf, paddedlen + mac_len);
 
+    /* Parse the packet */
+    if (!silc_packet_parse(packet)) {
+      silc_mutex_unlock(stream->lock);
+      SILC_PACKET_CALLBACK_ERROR(stream, SILC_PACKET_ERR_MALFORMED);
+      silc_mutex_lock(stream->lock);
+      silc_packet_free(packet);
+      memset(tmp, 0, sizeof(tmp));
+      return;
+    }
+
     /* Dispatch the packet to application */
-    packet->stream = stream;
     silc_packet_dispatch(packet);
   }