Added connection authentication request support.
[silc.git] / lib / silcclient / command_reply.c
index 55f8b4ab5f14a8eae15a7350e244ddacf584a95d..c1c7b190c2436e2487320dcebc4b2cfc05b718db 100644 (file)
@@ -4,7 +4,7 @@
 
   Author: Pekka Riikonen <priikone@silcnet.org>
 
-  Copyright (C) 1997 - 2006 Pekka Riikonen
+  Copyright (C) 1997 - 2007 Pekka Riikonen
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
 /************************** Types and definitions ***************************/
 
 /* Calls error command reply callback back to command sender. */
-#define ERROR_CALLBACK(error)                                  \
+#define ERROR_CALLBACK(err)                                    \
 do {                                                           \
   void *arg1 = NULL, *arg2 = NULL;                             \
   if (cmd->status != SILC_STATUS_OK)                           \
     silc_status_get_args(cmd->status, args, &arg1, &arg2);     \
   else                                                         \
-    cmd->status = error;                                       \
+    cmd->status = cmd->error = err;                            \
   SILC_LOG_DEBUG(("Error in command reply: %s",                        \
                 silc_get_status_message(cmd->status)));        \
   silc_client_command_callback(cmd, arg1, arg2);               \
@@ -46,8 +46,8 @@ do {                                                          \
          msg "%s", silc_get_status_message(cmd->error));               \
     ERROR_CALLBACK(cmd->error);                                                \
     silc_client_command_process_error(cmd, state_context, cmd->error); \
-    silc_fsm_next(fsm, silc_client_command_reply_process);             \
-    return SILC_FSM_CONTINUE;                                          \
+    silc_fsm_next(fsm, silc_client_command_reply_processed);           \
+    SILC_FSM_CONTINUE;                                         \
   }
 
 /* Check for correct arguments */
@@ -55,8 +55,8 @@ do {                                                          \
   if (silc_argument_get_arg_num(args) < min ||                 \
       silc_argument_get_arg_num(args) > max) {                 \
     ERROR_CALLBACK(SILC_STATUS_ERR_NOT_ENOUGH_PARAMS);         \
-    silc_fsm_next(fsm, silc_client_command_reply_process);     \
-    return SILC_FSM_CONTINUE;                                  \
+    silc_fsm_next(fsm, silc_client_command_reply_processed);   \
+    SILC_FSM_CONTINUE;                                 \
   }
 
 #define SAY cmd->conn->client->internal->ops->say
@@ -69,6 +69,7 @@ static inline void
 silc_client_command_callback(SilcClientCommandContext cmd, ...)
 {
   SilcClientCommandReplyCallback cb;
+  SilcList list;
   va_list ap, cp;
 
   va_start(ap, cmd);
@@ -83,8 +84,9 @@ silc_client_command_callback(SilcClientCommandContext cmd, ...)
   }
 
   /* Reply callback */
-  silc_list_start(cmd->reply_callbacks);
-  while ((cb = silc_list_get(cmd->reply_callbacks)))
+  list = cmd->reply_callbacks;
+  silc_list_start(list);
+  while ((cb = silc_list_get(list)))
     if (!cb->do_not_call) {
       silc_va_copy(cp, ap);
       cb->do_not_call = !cb->reply(cmd->conn->client, cmd->conn, cmd->cmd,
@@ -104,19 +106,53 @@ static void silc_client_command_process_error(SilcClientCommandContext cmd,
   SilcClient client = cmd->conn->client;
   SilcClientConnection conn = cmd->conn;
   SilcArgumentPayload args = silc_command_get_args(payload);
-  SilcClientEntry client_entry;
   SilcID id;
 
   if (cmd->error == SILC_STATUS_ERR_NO_SUCH_CLIENT_ID) {
+    SilcClientEntry client_entry;
+
     /* Remove unknown client entry from cache */
     if (!silc_argument_get_decoded(args, 2, SILC_ARGUMENT_ID, &id, NULL))
       return;
 
     client_entry = silc_client_get_client_by_id(client, conn, &id.u.client_id);
     if (client_entry) {
-      silc_client_unref_client(client, conn, client_entry);
+      silc_client_remove_from_channels(client, conn, client_entry);
       silc_client_del_client(client, conn, client_entry);
+      silc_client_unref_client(client, conn, client_entry);
+    }
+    return;
+  }
+
+  if (cmd->error == SILC_STATUS_ERR_NO_SUCH_CHANNEL_ID) {
+    SilcChannelEntry channel;
+
+    /* Remove unknown client entry from cache */
+    if (!silc_argument_get_decoded(args, 2, SILC_ARGUMENT_ID, &id, NULL))
+      return;
+
+    channel = silc_client_get_channel_by_id(client, conn, &id.u.channel_id);
+    if (channel) {
+      silc_client_empty_channel(client, conn, channel);
+      silc_client_del_channel(client, conn, channel);
+      silc_client_unref_channel(client, conn, channel);
     }
+    return;
+  }
+
+  if (cmd->error == SILC_STATUS_ERR_NO_SUCH_SERVER_ID) {
+    SilcServerEntry server_entry;
+
+    /* Remove unknown client entry from cache */
+    if (!silc_argument_get_decoded(args, 2, SILC_ARGUMENT_ID, &id, NULL))
+      return;
+
+    server_entry = silc_client_get_server_by_id(client, conn, &id.u.server_id);
+    if (server_entry) {
+      silc_client_del_server(client, conn, server_entry);
+      silc_client_unref_server(client, conn, server_entry);
+    }
+    return;
   }
 }
 
@@ -138,7 +174,7 @@ SILC_FSM_STATE(silc_client_command_reply)
   silc_packet_free(packet);
   if (!payload) {
     SILC_LOG_DEBUG(("Bad command reply packet"));
-    return SILC_FSM_FINISH;
+    SILC_FSM_FINISH;
   }
 
   cmd_ident = silc_command_get_ident(payload);
@@ -157,9 +193,10 @@ SILC_FSM_STATE(silc_client_command_reply)
   silc_mutex_unlock(conn->internal->lock);
 
   if (!cmd) {
-    SILC_LOG_DEBUG(("Unknown command reply"));
+    SILC_LOG_DEBUG(("Unknown command reply %s, ident %d",
+                   silc_get_command_name(command), cmd_ident));
     silc_command_payload_free(payload);
-    return SILC_FSM_FINISH;
+    SILC_FSM_FINISH;
   }
 
   /* Signal command thread that command reply has arrived */
@@ -167,19 +204,22 @@ SILC_FSM_STATE(silc_client_command_reply)
   silc_fsm_next(&cmd->thread, silc_client_command_reply_process);
   silc_fsm_continue_sync(&cmd->thread);
 
-  return SILC_FSM_FINISH;
+  SILC_FSM_FINISH;
 }
 
 /* Wait here for command reply to arrive from remote host */
 
 SILC_FSM_STATE(silc_client_command_reply_wait)
 {
+  SilcClientCommandContext cmd = fsm_context;
+
   SILC_LOG_DEBUG(("Wait for command reply"));
 
   /** Wait for command reply */
   silc_fsm_set_state_context(fsm, NULL);
-  silc_fsm_next_later(fsm, silc_client_command_reply_timeout, 20, 0);
-  return SILC_FSM_WAIT;
+  silc_fsm_next_later(fsm, silc_client_command_reply_timeout,
+                     cmd->cmd != SILC_COMMAND_PING ? 25 : 60, 0);
+  SILC_FSM_WAIT;
 }
 
 /* Timeout occurred while waiting command reply */
@@ -187,11 +227,23 @@ SILC_FSM_STATE(silc_client_command_reply_wait)
 SILC_FSM_STATE(silc_client_command_reply_timeout)
 {
   SilcClientCommandContext cmd = fsm_context;
+  SilcClientConnection conn = cmd->conn;
   SilcArgumentPayload args = NULL;
 
+  if (conn->internal->disconnected) {
+    SILC_LOG_DEBUG(("Command %s canceled", silc_get_command_name(cmd->cmd)));
+    silc_list_del(conn->internal->pending_commands, cmd);
+    if (!cmd->called)
+      ERROR_CALLBACK(SILC_STATUS_ERR_TIMEDOUT);
+    SILC_FSM_FINISH;
+  }
+
+  SILC_LOG_DEBUG(("Command %s timeout", silc_get_command_name(cmd->cmd)));
+
   /* Timeout, reply not received in timely fashion */
+  silc_list_del(conn->internal->pending_commands, cmd);
   ERROR_CALLBACK(SILC_STATUS_ERR_TIMEDOUT);
-  return SILC_FSM_FINISH;
+  SILC_FSM_FINISH;
 }
 
 /* Process received command reply payload */
@@ -313,10 +365,10 @@ SILC_FSM_STATE(silc_client_command_reply_process)
     silc_fsm_next(fsm, silc_client_command_reply_service);
     break;
   default:
-    return SILC_FSM_FINISH;
+    SILC_FSM_FINISH;
   }
 
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /* Completes command reply processing */
@@ -331,7 +383,7 @@ SILC_FSM_STATE(silc_client_command_reply_processed)
 
   if (cmd->status == SILC_STATUS_OK || cmd->status == SILC_STATUS_LIST_END ||
       SILC_STATUS_IS_ERROR(cmd->status))
-    return SILC_FSM_FINISH;
+    SILC_FSM_FINISH;
 
   /* Add back to pending command reply list */
   silc_mutex_lock(conn->internal->lock);
@@ -341,7 +393,7 @@ SILC_FSM_STATE(silc_client_command_reply_processed)
 
   /** Wait more command payloads */
   silc_fsm_next(fsm, silc_client_command_reply_wait);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /******************************** WHOIS *************************************/
@@ -419,7 +471,7 @@ SILC_FSM_STATE(silc_client_command_reply_whois)
       silc_client_add_client(client, conn, nickname, username, realname,
                             &id.u.client_id, mode);
     if (!client_entry) {
-      ERROR_CALLBACK(SILC_STATUS_ERR_NOT_ENOUGH_PARAMS);
+      ERROR_CALLBACK(SILC_STATUS_ERR_RESOURCE_LIMIT);
       goto out;
     }
     silc_client_ref_client(client, conn, client_entry);
@@ -461,7 +513,7 @@ SILC_FSM_STATE(silc_client_command_reply_whois)
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /******************************** WHOWAS ************************************/
@@ -509,7 +561,7 @@ SILC_FSM_STATE(silc_client_command_reply_whowas)
  out:
   silc_client_unref_client(client, conn, client_entry);
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /******************************** IDENTIFY **********************************/
@@ -555,7 +607,7 @@ SILC_FSM_STATE(silc_client_command_reply_identify)
        silc_client_add_client(client, conn, name, info, NULL,
                               &id.u.client_id, 0);
       if (!client_entry) {
-       ERROR_CALLBACK(SILC_STATUS_ERR_NOT_ENOUGH_PARAMS);
+       ERROR_CALLBACK(SILC_STATUS_ERR_RESOURCE_LIMIT);
        goto out;
       }
       silc_client_ref_client(client, conn, client_entry);
@@ -582,6 +634,7 @@ SILC_FSM_STATE(silc_client_command_reply_identify)
        ERROR_CALLBACK(SILC_STATUS_ERR_NOT_ENOUGH_PARAMS);
        goto out;
       }
+      silc_client_ref_server(client, conn, server_entry);
     } else {
       silc_client_update_server(client, conn, server_entry, name, info);
     }
@@ -589,6 +642,7 @@ SILC_FSM_STATE(silc_client_command_reply_identify)
 
     /* Notify application */
     silc_client_command_callback(cmd, server_entry, name, info);
+    silc_client_unref_server(client, conn, server_entry);
     break;
 
   case SILC_ID_CHANNEL:
@@ -598,7 +652,7 @@ SILC_FSM_STATE(silc_client_command_reply_identify)
     channel_entry = silc_client_get_channel_by_id(client, conn,
                                                  &id.u.channel_id);
     if (!channel_entry) {
-      SILC_LOG_DEBUG(("Adding new channel entry (IDENTIFY"));
+      SILC_LOG_DEBUG(("Adding new channel entry (IDENTIFY)"));
 
       if (!name) {
        ERROR_CALLBACK(SILC_STATUS_ERR_NOT_ENOUGH_PARAMS);
@@ -612,16 +666,18 @@ SILC_FSM_STATE(silc_client_command_reply_identify)
        ERROR_CALLBACK(SILC_STATUS_ERR_NOT_ENOUGH_PARAMS);
        goto out;
       }
+      silc_client_ref_channel(client, conn, channel_entry);
     }
 
     /* Notify application */
     silc_client_command_callback(cmd, channel_entry, name, info);
+    silc_client_unref_channel(client, conn, channel_entry);
     break;
   }
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** NICK ************************************/
@@ -635,7 +691,7 @@ SILC_FSM_STATE(silc_client_command_reply_nick)
   SilcClient client = conn->client;
   SilcCommandPayload payload = state_context;
   SilcArgumentPayload args = silc_command_get_args(payload);
-  unsigned char *tmp, *nick, *idp;
+  unsigned char *nick, *idp;
   SilcUInt32 len, idp_len;
   SilcClientID old_client_id;
   SilcID id;
@@ -644,8 +700,6 @@ SILC_FSM_STATE(silc_client_command_reply_nick)
   CHECK_STATUS("Cannot set nickname: ");
   CHECK_ARGS(2, 3);
 
-  old_client_id = *conn->local_id;
-
   /* Take received Client ID */
   idp = silc_argument_get_arg_type(args, 2, &idp_len);
   if (!idp) {
@@ -664,34 +718,13 @@ SILC_FSM_STATE(silc_client_command_reply_nick)
     goto out;
   }
 
-  /* Normalize nickname */
-  tmp = silc_identifier_check(nick, len, SILC_STRING_UTF8, 128, NULL);
-  if (!tmp) {
-    ERROR_CALLBACK(SILC_STATUS_ERR_BAD_NICKNAME);
-    goto out;
-  }
-
-  /* Update the client entry */
-  silc_mutex_lock(conn->internal->lock);
-  if (!silc_idcache_update(conn->internal->client_cache,
-                          conn->internal->local_entry,
-                          &conn->local_entry->id,
-                          &id.u.client_id,
-                          conn->local_entry->nickname_normalized,
-                          tmp, TRUE)) {
-    silc_free(tmp);
-    silc_mutex_unlock(conn->internal->lock);
+  /* Change the nickname */
+  old_client_id = *conn->local_id;
+  if (!silc_client_change_nickname(client, conn, conn->local_entry,
+                                  nick, &id.u.client_id, idp, idp_len)) {
     ERROR_CALLBACK(SILC_STATUS_ERR_BAD_NICKNAME);
     goto out;
   }
-  silc_mutex_unlock(conn->internal->lock);
-  memset(conn->local_entry->nickname, 0, sizeof(conn->local_entry->nickname));
-  memcpy(conn->local_entry->nickname, nick, len);
-  conn->local_entry->nickname_normalized = tmp;
-  silc_buffer_enlarge(conn->internal->local_idp, idp_len);
-  silc_buffer_put(conn->internal->local_idp, idp, idp_len);
-  silc_client_nickname_format(client, conn, conn->local_entry);
-  silc_packet_set_ids(conn->stream, SILC_ID_CLIENT, conn->local_id, 0, NULL);
 
   /* Notify application */
   silc_client_command_callback(cmd, conn->local_entry,
@@ -699,7 +732,7 @@ SILC_FSM_STATE(silc_client_command_reply_nick)
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** LIST ************************************/
@@ -715,7 +748,7 @@ SILC_FSM_STATE(silc_client_command_reply_list)
   SilcArgumentPayload args = silc_command_get_args(payload);
   unsigned char *tmp, *name, *topic;
   SilcUInt32 usercount = 0;
-  SilcChannelEntry channel_entry;
+  SilcChannelEntry channel_entry = NULL;
   SilcID id;
 
   /* Sanity checks */
@@ -725,7 +758,7 @@ SILC_FSM_STATE(silc_client_command_reply_list)
     /* There were no channels in the network. */
     silc_client_command_callback(cmd, NULL, NULL, NULL, 0);
     silc_fsm_next(fsm, silc_client_command_reply_processed);
-    return SILC_FSM_CONTINUE;
+    SILC_FSM_CONTINUE;
   }
 
   CHECK_ARGS(3, 5);
@@ -752,14 +785,16 @@ SILC_FSM_STATE(silc_client_command_reply_list)
       ERROR_CALLBACK(SILC_STATUS_ERR_NOT_ENOUGH_PARAMS);
       goto out;
     }
+    silc_client_ref_channel(client, conn, channel_entry);
   }
 
   /* Notify application */
   silc_client_command_callback(cmd, channel_entry, name, topic, usercount);
 
  out:
+  silc_client_unref_channel(client, conn, channel_entry);
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************* TOPIC ************************************/
@@ -807,7 +842,7 @@ SILC_FSM_STATE(silc_client_command_reply_topic)
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************* INVITE ***********************************/
@@ -857,7 +892,7 @@ SILC_FSM_STATE(silc_client_command_reply_invite)
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** KILL ************************************/
@@ -889,15 +924,16 @@ SILC_FSM_STATE(silc_client_command_reply_kill)
   /* Notify application */
   silc_client_command_callback(cmd, client_entry);
 
-  /* Remove the client from all channels and free it */
+  /* Remove the client */
   if (client_entry) {
+    silc_client_remove_from_channels(client, conn, client_entry);
     silc_client_del_client(client, conn, client_entry);
     silc_client_unref_client(client, conn, client_entry);
   }
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** INFO ************************************/
@@ -943,20 +979,22 @@ SILC_FSM_STATE(silc_client_command_reply_info)
   /* See whether we have this server cached. If not create it. */
   server = silc_client_get_server_by_id(client, conn, &id.u.server_id);
   if (!server) {
-    SILC_LOG_DEBUG(("New server entry"));
+    SILC_LOG_DEBUG(("Add new server entry (INFO)"));
     server = silc_client_add_server(client, conn, server_name,
                                    server_info, &id.u.server_id);
     if (!server)
       goto out;
+    silc_client_ref_server(client, conn, server);
   }
 
   /* Notify application */
   silc_client_command_callback(cmd, server, server->server_name,
                               server->server_info);
+  silc_client_unref_server(client, conn, server);
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** STATS ***********************************/
@@ -1013,7 +1051,7 @@ SILC_FSM_STATE(silc_client_command_reply_stats)
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** PING ************************************/
@@ -1037,7 +1075,7 @@ SILC_FSM_STATE(silc_client_command_reply_ping)
   silc_client_command_callback(cmd);
 
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** JOIN ************************************/
@@ -1076,7 +1114,6 @@ SILC_FSM_STATE(silc_client_command_reply_join)
   const char *cipher;
   SilcBufferStruct client_id_list, client_mode_list, keyp;
   SilcHashTableList htl;
-  SilcDList chpks = NULL;
   SilcID id;
   int i;
 
@@ -1164,15 +1201,13 @@ SILC_FSM_STATE(silc_client_command_reply_join)
     /* Mode */
     SILC_GET32_MSB(mode, client_mode_list.data);
 
-    SILC_LOG_DEBUG(("id %s", silc_id_render(&id.u.client_id, SILC_ID_CLIENT)));
-
     /* Get client entry */
     client_entry = silc_client_get_client_by_id(client, conn, &id.u.client_id);
     if (!client_entry)
       continue;
 
     /* Join client to the channel */
-    silc_client_add_to_channel(channel, client_entry, mode);
+    silc_client_add_to_channel(client, conn, channel, client_entry, mode);
     silc_client_unref_client(client, conn, client_entry);
 
     if (!silc_buffer_pull(&client_id_list, idp_len))
@@ -1232,8 +1267,8 @@ SILC_FSM_STATE(silc_client_command_reply_join)
   /* Get channel public key list */
   tmp = silc_argument_get_arg_type(args, 16, &len);
   if (tmp)
-    chpks = silc_argument_list_parse_decoded(tmp, len,
-                                            SILC_ARGUMENT_PUBLIC_KEY);
+    channel->channel_pubkeys =
+      silc_argument_list_parse_decoded(tmp, len, SILC_ARGUMENT_PUBLIC_KEY);
 
   /* Set current channel */
   conn->current_channel = channel;
@@ -1245,16 +1280,14 @@ SILC_FSM_STATE(silc_client_command_reply_join)
   /* Notify application */
   silc_client_command_callback(cmd, channel_name, channel, mode, &htl,
                               topic, cipher, hmac, channel->founder_key,
-                              chpks, channel->user_limit);
+                              channel->channel_pubkeys, channel->user_limit);
 
-  if (chpks)
-    silc_argument_list_free(chpks, SILC_ARGUMENT_PUBLIC_KEY);
   silc_hash_table_list_reset(&htl);
   silc_client_unref_channel(client, conn, channel);
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** MOTD ************************************/
@@ -1308,7 +1341,7 @@ SILC_FSM_STATE(silc_client_command_reply_motd)
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** UMODE ***********************************/
@@ -1342,7 +1375,7 @@ SILC_FSM_STATE(silc_client_command_reply_umode)
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** CMODE ***********************************/
@@ -1420,7 +1453,7 @@ SILC_FSM_STATE(silc_client_command_reply_cmode)
   if (public_key)
     silc_pkcs_public_key_free(public_key);
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** CUMODE **********************************/
@@ -1491,7 +1524,7 @@ SILC_FSM_STATE(silc_client_command_reply_cumode)
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** KICK ************************************/
@@ -1544,7 +1577,7 @@ SILC_FSM_STATE(silc_client_command_reply_kick)
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /******************************** SILCOPER **********************************/
@@ -1563,7 +1596,7 @@ SILC_FSM_STATE(silc_client_command_reply_silcoper)
   silc_client_command_callback(cmd);
 
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** OPER ************************************/
@@ -1582,7 +1615,7 @@ SILC_FSM_STATE(silc_client_command_reply_oper)
   silc_client_command_callback(cmd);
 
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************* DETACH ***********************************/
@@ -1600,22 +1633,20 @@ SILC_FSM_STATE(silc_client_command_reply_detach)
   CHECK_STATUS("Cannot detach: ");
   CHECK_ARGS(1, 1);
 
-  /* Notify application */
-  silc_client_command_callback(cmd);
-
-#if 0
-  /* Generate the detachment data and deliver it to the client in the
-     detach client operation */
+  /* Get detachment data */
   detach = silc_client_get_detach_data(client, conn);
-  if (detach) {
-    client->internal->ops->detach(client, conn, silc_buffer_data(detach),
-                                 silc_buffer_len(detach));
-    silc_buffer_free(detach);
+  if (!detach) {
+    ERROR_CALLBACK(SILC_STATUS_ERR_RESOURCE_LIMIT);
+    goto out;
   }
-#endif /* 0 */
 
+  /* Notify application */
+  silc_client_command_callback(cmd, detach);
+  silc_buffer_free(detach);
+
+ out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** WATCH ***********************************/
@@ -1634,7 +1665,7 @@ SILC_FSM_STATE(silc_client_command_reply_watch)
   silc_client_command_callback(cmd);
 
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /*********************************** BAN ************************************/
@@ -1682,7 +1713,7 @@ SILC_FSM_STATE(silc_client_command_reply_ban)
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** LEAVE ***********************************/
@@ -1717,17 +1748,18 @@ SILC_FSM_STATE(silc_client_command_reply_leave)
   }
 
   /* Remove us from this channel. */
-  silc_client_remove_from_channel(channel, conn->local_entry);
+  silc_client_remove_from_channel(client, conn, channel, conn->local_entry);
 
   /* Notify application */
   silc_client_command_callback(cmd, channel);
 
   /* Now delete the channel. */
+  silc_client_empty_channel(client, conn, channel);
   silc_client_del_channel(client, conn, channel);
 
  out:
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************* USERS ************************************/
@@ -1784,7 +1816,7 @@ SILC_FSM_STATE(silc_client_command_reply_users)
   SilcUInt16 idp_len, mode;
   SilcHashTableList htl;
   SilcBufferStruct client_id_list, client_mode_list;
-  SilcChannelEntry channel;
+  SilcChannelEntry channel = NULL;
   SilcClientEntry client_entry;
   SilcID id;
   int i;
@@ -1828,6 +1860,7 @@ SILC_FSM_STATE(silc_client_command_reply_users)
   /* Resolve users we do not know about */
   if (!cmd->resolved) {
     cmd->resolved = TRUE;
+    silc_client_unref_channel(client, conn, channel);
     SILC_FSM_CALL(silc_client_get_clients_by_list(
                          client, conn, list_count, &client_id_list,
                          silc_client_command_reply_users_resolved, cmd));
@@ -1858,7 +1891,7 @@ SILC_FSM_STATE(silc_client_command_reply_users)
        clearly do not exist since the resolving didn't find them. */
     client_entry = silc_client_get_client_by_id(client, conn, &id.u.client_id);
     if (client_entry)
-      silc_client_add_to_channel(channel, client_entry, mode);
+      silc_client_add_to_channel(client, conn, channel, client_entry, mode);
     silc_client_unref_client(client, conn, client_entry);
 
     if (!silc_buffer_pull(&client_id_list, idp_len))
@@ -1873,8 +1906,9 @@ SILC_FSM_STATE(silc_client_command_reply_users)
   silc_hash_table_list_reset(&htl);
 
  out:
+  silc_client_unref_channel(client, conn, channel);
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** GETKEY **********************************/
@@ -1954,13 +1988,14 @@ SILC_FSM_STATE(silc_client_command_reply_getkey)
     /* Notify application */
     silc_client_command_callback(cmd, SILC_ID_SERVER, server_entry,
                                 server_entry->public_key);
+    silc_client_unref_server(client, conn, server_entry);
   }
 
  out:
   if (public_key)
     silc_pkcs_public_key_free(public_key);
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /********************************** SERVICE *********************************/
@@ -1989,7 +2024,7 @@ SILC_FSM_STATE(silc_client_command_reply_service)
   silc_client_command_callback(cmd, service_list, name);
 
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }
 
 /*********************************** QUIT ***********************************/
@@ -1999,5 +2034,5 @@ SILC_FSM_STATE(silc_client_command_reply_service)
 SILC_FSM_STATE(silc_client_command_reply_quit)
 {
   silc_fsm_next(fsm, silc_client_command_reply_processed);
-  return SILC_FSM_CONTINUE;
+  SILC_FSM_CONTINUE;
 }