From: Jochen Eisinger Date: Fri, 2 Sep 2005 21:44:07 +0000 (+0000) Subject: Fri Sep 2 23:44:37 CEST 2005 Jochen Eisinger X-Git-Tag: silc.toolkit.1.0.1~21 X-Git-Url: http://git.silcnet.org/gitweb/?p=silc.git;a=commitdiff_plain;h=2cfa73e84657b523bab1582931a8dac593f36b97 Fri Sep 2 23:44:37 CEST 2005 Jochen Eisinger * Fixed the insecure temporary file creation issue now that it's even on bugtraq... Affected file apps/silcd/silcd.c --- diff --git a/CHANGES b/CHANGES index cd20f109..ee11e78b 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,8 @@ +Fri Sep 2 23:44:37 CEST 2005 Jochen Eisinger + + * Fixed the insecure temporary file creation issue now that it's + even on bugtraq... Affected file apps/silcd/silcd.c + Wed Aug 24 18:27:48 CEST 2005 Patrik Weiskircher * Before creating a channel key we need to remove the private key diff --git a/apps/silcd/silcd.c b/apps/silcd/silcd.c index 9c02f13a..a727f2a9 100644 --- a/apps/silcd/silcd.c +++ b/apps/silcd/silcd.c @@ -264,8 +264,8 @@ SILC_TASK_CALLBACK(dump_stats) char filename[256]; memset(filename, 0, sizeof(filename)); - snprintf(filename, sizeof(filename) - 1, "/tmp/silcd.%d.stats", getpid()); - fdd = fopen(filename, "w+"); + snprintf(filename, sizeof(filename) - 1, "/tmp/silcd.%d.stats-XXXXXX", getpid()); + fdd = mkstemp(filename); if (!fdd) return;