ASN1: Fix NULL pointer dereference on stack allocation failure.

If the second silc_stack_alloc fails, then asn1->stack2 is NULL.  Thus,
when silc_asn1_init calls silc_stack_free(asn1->stack2), it is
equivalent to silc_stack_free(NULL).  However, silc_stack_free does not
check for a NULL pointer.  Fix silc_asn1_init to free asn1->stack1, as
was intended.

diff --git a/lib/silcasn1/silcasn1.c b/lib/silcasn1/silcasn1.c
index 5965228be1990640b2e4adf16578f2502d362f77..2e43b49c233631a017cabee0c7b9d07791e643c3 100644 (file)
--- a/lib/silcasn1/silcasn1.c
+++ b/lib/silcasn1/silcasn1.c
@@ -53,7 +53,7 @@ SilcBool silc_asn1_init(SilcAsn1 asn1)
 
   asn1->stack2 = silc_stack_alloc(768);
   if (!asn1->stack2) {
 
   asn1->stack2 = silc_stack_alloc(768);
   if (!asn1->stack2) {

-    silc_stack_free(asn1->stack2);
+    silc_stack_free(asn1->stack1);

     return FALSE;
   }
 
     return FALSE;
   }