X-Git-Url: http://git.silcnet.org/gitweb/?p=silc.git;a=blobdiff_plain;f=lib%2Fsilcasn1%2Fsilcasn1_encode.c;h=986909c4d7348cdd43e4146dc9cb9f217510e381;hp=d8706b73a9dbd31643d3a0c99913a63cea5f0ac9;hb=ebfe5dc8641467efea3506a4797a2b1260b2da55;hpb=410642a14d4185abd75715cee3f5177cd55b1ceb diff --git a/lib/silcasn1/silcasn1_encode.c b/lib/silcasn1/silcasn1_encode.c index d8706b73..986909c4 100644 --- a/lib/silcasn1/silcasn1_encode.c +++ b/lib/silcasn1/silcasn1_encode.c @@ -4,7 +4,7 @@ Author: Pekka Riikonen - Copyright (C) 2003 - 2005 Pekka Riikonen + Copyright (C) 2003 - 2007 Pekka Riikonen This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -21,6 +21,8 @@ #include "silcasn1.h" #include "silcber.h" +#define SILC_ASN1_BUFFER_FREE(b, stack) if (!stack) silc_buffer_purge(b); + /************************** ASN.1 Encoder routines **************************/ /* Encode string from UTF-8 string to other string encodings. Encodes @@ -36,7 +38,7 @@ goto fail; \ } \ silc_stack_push(asn1->stack2, &frame); \ - s = silc_smalloc_ua(stack2, s_len + 1); \ + s = silc_smalloc(stack2, s_len + 1); \ if (s) { \ silc_utf8_decode(d, d_len, (enc), s, s_len); \ s[s_len] = '\0'; \ @@ -136,10 +138,10 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, ret = silc_asn1_encoder(asn1, stack2, stack1, type, type, SILC_BER_CLASS_UNIVERSAL, opts, &buf, depth + 1, primitive); - silc_stack_pop(stack2); if (!ret) { SILC_LOG_DEBUG(("Error encoding explicit tag")); + silc_stack_pop(stack2); goto fail; } @@ -149,6 +151,8 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, silc_buffer_truelen(dest) + len); ret = silc_ber_encode(dest, ber_class, SILC_BER_ENC_CONSTRUCTED, tag, buf.data, silc_buffer_len(&buf), FALSE); + SILC_ASN1_BUFFER_FREE(&buf, stack2); + silc_stack_pop(stack2); if (!ret) goto fail; if (primitive) { @@ -237,9 +241,9 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, silc_stack_push(stack2, &frame); ret = silc_asn1_encoder(asn1, stack2, stack1, rtype, rtag, rclass, ropts, &buf, depth + 1, FALSE); - silc_stack_pop(stack2); if (!ret) { SILC_LOG_DEBUG(("Error traversing a SEQUENCE/SET")); + silc_stack_pop(stack2); goto fail; } @@ -249,6 +253,8 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, silc_buffer_truelen(dest) + len); ret = silc_ber_encode(dest, ber_class, SILC_BER_ENC_CONSTRUCTED, tag, buf.data, silc_buffer_len(&buf), indef); + SILC_ASN1_BUFFER_FREE(&buf, stack2); + silc_stack_pop(stack2); if (!ret) goto fail; break; @@ -286,26 +292,66 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, silc_buffer_truelen(dest) + len); ret = silc_ber_encode(dest, ber_class, SILC_BER_ENC_PRIMITIVE, tag, buf.data, silc_buffer_len(&buf), FALSE); + SILC_ASN1_BUFFER_FREE(&buf, stack2); + silc_stack_pop(stack2); + if (!ret) + goto fail; + break; + } + + case SILC_ASN1_TAG_SHORT_INTEGER: + { + /* Short Integer */ + SilcUInt32 sint = va_arg(asn1->ap, SilcUInt32); + SilcMPInt z; + + if (tag == SILC_ASN1_TAG_SHORT_INTEGER) + tag = SILC_ASN1_TAG_INTEGER; + + memset(&buf, 0, sizeof(buf)); + + silc_stack_push(stack2, &frame); + silc_mp_sinit(stack2, &z); + silc_mp_set_ui(&z, sint); + + len = silc_mp_sizeinbase(&z, 2); + if (!(len & 7)) + len = ((len + 7) / 8) + 1; + else + len = (len + 7) / 8; + silc_buffer_srealloc_size(stack2, &buf, + silc_buffer_truelen(&buf) + len); + buf.data[0] = 0x00; + silc_mp_mp2bin_noalloc(&z, buf.data, silc_buffer_len(&buf)); + silc_mp_uninit(&z); + + /* Encode the integer */ + len = silc_ber_encoded_len(tag, len, indef); + dest = silc_buffer_srealloc_size(stack1, dest, + silc_buffer_truelen(dest) + len); + ret = silc_ber_encode(dest, ber_class, SILC_BER_ENC_PRIMITIVE, + tag, buf.data, silc_buffer_len(&buf), FALSE); + SILC_ASN1_BUFFER_FREE(&buf, stack2); silc_stack_pop(stack2); if (!ret) goto fail; break; } + break; case SILC_ASN1_TAG_OID: { /* Object identifier */ char *cp, *oidstr = va_arg(asn1->ap, char *); SilcUInt32 words[24], oid, mask; - int i, c = -1; + int i, k, c = 0; if (!oidstr) break; /* Get OID words from the string */ cp = strchr(oidstr, '.'); while (cp) { - c = sscanf(oidstr, "%lu", (unsigned long *)&oid); - if (c < 1) { + if (sscanf(oidstr, "%u", &oid) != 1) { SILC_LOG_DEBUG(("Malformed OID string")); goto fail; } @@ -314,6 +360,17 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, words[c++] = oid; oidstr = cp + 1; cp = strchr(oidstr, '.'); + + if (!cp) { + if (sscanf(oidstr, "%u", &oid) != 1) { + SILC_LOG_DEBUG(("Malformed OID string")); + goto fail; + } + if (c + 1 > sizeof(words) / sizeof(words[0])) + goto fail; + words[c++] = oid; + break; + } } if (c < 2) { SILC_LOG_DEBUG(("Malfromed OID string")); @@ -339,7 +396,7 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, for (i = 2, len = 1; i < c; i++) { oid = words[i]; if (oid) { - c = len; + k = len; mask = 0; while (oid) { buf.data[len++] = (oid & 0x7f) | mask; @@ -347,11 +404,11 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, mask |= 0x80; } mask = len - 1; - while (c < mask) { - oid = buf.data[c]; - buf.data[c] = buf.data[mask]; + while (k < mask) { + oid = buf.data[k]; + buf.data[k] = buf.data[mask]; buf.data[mask] = oid; - c++; + k++; mask--; } @@ -360,11 +417,12 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, buf.data[len++] = 0x00; } - len = silc_ber_encoded_len(tag, len, indef); + len = silc_ber_encoded_len(tag, silc_buffer_len(&buf), indef); dest = silc_buffer_srealloc_size(stack1, dest, silc_buffer_truelen(dest) + len); ret = silc_ber_encode(dest, ber_class, SILC_BER_ENC_PRIMITIVE, tag, buf.data, silc_buffer_len(&buf), FALSE); + SILC_ASN1_BUFFER_FREE(&buf, stack2); silc_stack_pop(stack2); if (!ret) goto fail; @@ -414,6 +472,7 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, silc_buffer_truelen(dest) + len); ret = silc_ber_encode(dest, ber_class, SILC_BER_ENC_PRIMITIVE, tag, buf.data, silc_buffer_len(&buf), indef); + SILC_ASN1_BUFFER_FREE(&buf, stack2); silc_stack_pop(stack2); if (!ret) goto fail; @@ -506,8 +565,17 @@ silc_asn1_encoder(SilcAsn1 asn1, SilcStack stack1, SilcStack stack2, case SILC_ASN1_TAG_OCTET_STRING: { - /* Octet string. We put it in as 8-bit ASCII */ - SILC_ASN1_ENCODE_STRING(SILC_STRING_ASCII); + /* Octet string. Put data as is. */ + unsigned char *d = va_arg(asn1->ap, unsigned char *); + SilcUInt32 d_len = va_arg(asn1->ap, SilcUInt32); + + len = silc_ber_encoded_len(tag, d_len, indef); + dest = silc_buffer_srealloc_size(stack1, dest, + silc_buffer_truelen(dest) + len); + ret = silc_ber_encode(dest, ber_class, SILC_BER_ENC_PRIMITIVE, + tag, d, d_len, indef); + if (!ret) + goto fail; break; } @@ -637,7 +705,6 @@ SilcBool silc_asn1_encode(SilcAsn1 asn1, SilcBuffer dest, ...) SILC_ASN1_ARGS(asn1, type, tag, ber_class, opts); if (!type) { va_end(asn1->ap); - asn1->ap = NULL; return FALSE; } @@ -692,7 +759,6 @@ SilcBool silc_asn1_encode(SilcAsn1 asn1, SilcBuffer dest, ...) asn1->stack1 = stack1; va_end(asn1->ap); - asn1->ap = NULL; return ret; }