From c8cad7cfe376df820ea8453fbcf7b37bcbb5134e Mon Sep 17 00:00:00 2001 From: Pekka Riikonen Date: Thu, 13 Mar 2008 11:52:15 +0000 Subject: [PATCH] Fixed NEW_CLIENT packet processing crash when the packet doesn't include nickname. --- CHANGES | 6 ++++++ apps/silcd/packet_receive.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index e6d976c8..128c76fc 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,9 @@ +Thu Mar 13 13:31:35 EET 2008 Pekka Riikonen + + * Fixed silcd crash in NEW_CLIENT packet handling when nickname + is not present in the packet. Affected files are + apps/silcd/packet_receive.c. + Fri Feb 22 16:12:27 EET 2008 Pekka Riikonen * Fixed partial encryption in CTR mode in AES. Change does not diff --git a/apps/silcd/packet_receive.c b/apps/silcd/packet_receive.c index c2c57ed7..786c21a0 100644 --- a/apps/silcd/packet_receive.c +++ b/apps/silcd/packet_receive.c @@ -2145,7 +2145,7 @@ SilcClientEntry silc_server_new_client(SilcServer server, if (silc_buffer_unformat(buffer, SILC_STR_UI16_NSTRING_ALLOC(&nickname, &nickname_len), - SILC_STR_END)) { + SILC_STR_END) >= 0) { if (nickname_len > 128) { nickname_len = 128; nickname[nickname_len - 1] = '\0'; -- 2.24.0