From: Pekka Riikonen <priikone@silcnet.org>
Date: Sat, 12 Apr 2008 10:50:09 +0000 (+0300)
Subject: Removed wrong SILC_LOG_ERROR and assert check from silc_idcache_add.
X-Git-Tag: 1.2.beta4~12^2~16
X-Git-Url: http://git.silcnet.org/gitweb/?p=runtime.git;a=commitdiff_plain;h=01ad96cb7e509ac24c73220a2fa7c43fdd6cb70c

Removed wrong SILC_LOG_ERROR and assert check from silc_idcache_add.

In some cases it is not fatal error to attempt to add entry that already
exists.  Removed the assert and changed the error to debug message.
---

diff --git a/lib/silcapputil/silcidcache.c b/lib/silcapputil/silcidcache.c
index a6d8c26e..831970d5 100644
--- a/lib/silcapputil/silcidcache.c
+++ b/lib/silcapputil/silcidcache.c
@@ -142,9 +142,8 @@ silc_idcache_add(SilcIDCache cache, char *name, void *id, void *context)
   if (id) {
     /* See if this entry is added already to cache */
     if (silc_idcache_find_by_id_one(cache, id, NULL)) {
-      SILC_LOG_ERROR(("Attempted to add same ID twice to ID Cache, id %s",
+      SILC_LOG_DEBUG(("Attempted to add same ID twice to ID Cache, id %s",
 		      silc_id_render(id, cache->id_type)));
-      SILC_ASSERT(FALSE);
       goto err;
     }
   }