From 32bb5a4547be4c1c51a5219f56b230242e782301 Mon Sep 17 00:00:00 2001 From: Jochen Eisinger Date: Mon, 5 Sep 2005 16:41:45 +0000 Subject: [PATCH] Mon Sep 5 18:40:22 CEST 2005 Jochen Eisinger * mkstemp returns -1 on error, thanks to brad@comstyle.com for pointing this out. Affected file apps/silcd/silcd.c --- CHANGES | 5 +++++ apps/silcd/silcd.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index ee11e78b..551b7bcd 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,8 @@ +Mon Sep 5 18:40:22 CEST 2005 Jochen Eisinger + + * mkstemp returns -1 on error, thanks to brad@comstyle.com for + pointing this out. Affected file apps/silcd/silcd.c + Fri Sep 2 23:44:37 CEST 2005 Jochen Eisinger * Fixed the insecure temporary file creation issue now that it's diff --git a/apps/silcd/silcd.c b/apps/silcd/silcd.c index a727f2a9..7d5d3beb 100644 --- a/apps/silcd/silcd.c +++ b/apps/silcd/silcd.c @@ -266,7 +266,7 @@ SILC_TASK_CALLBACK(dump_stats) memset(filename, 0, sizeof(filename)); snprintf(filename, sizeof(filename) - 1, "/tmp/silcd.%d.stats-XXXXXX", getpid()); fdd = mkstemp(filename); - if (!fdd) + if (fdd == -1) return; #define STAT_OUTPUT(fmt, stat) fprintf(fdd, fmt "\n", (int)stat); -- 2.43.0