X-Git-Url: http://git.silcnet.org/gitweb/?a=blobdiff_plain;f=lib%2Fsilcclient%2Fclient_connect.c;h=de87143f047ff3f9dc6be0eb51df4c66b2743fd9;hb=52e57c880aba9c5e89f59d962eb9af75670b76e0;hp=98b4372f3a698bb71f0a1e0ea255fa37b1a8d036;hpb=7c574a294504ec55bbd7e7686186832c0f4095ae;p=silc.git diff --git a/lib/silcclient/client_connect.c b/lib/silcclient/client_connect.c index 98b4372f..de87143f 100644 --- a/lib/silcclient/client_connect.c +++ b/lib/silcclient/client_connect.c @@ -4,7 +4,7 @@ Author: Pekka Riikonen - Copyright (C) 2006 Pekka Riikonen + Copyright (C) 2006 - 2007 Pekka Riikonen This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -79,8 +79,7 @@ static void silc_client_connect_callback(SilcNetStatus status, if (status != SILC_NET_OK) { /* Notify application of failure */ SILC_LOG_DEBUG(("Connecting failed")); - conn->callback(client, conn, SILC_CLIENT_CONN_ERROR, 0, - NULL, conn->callback_context); + conn->internal->status = SILC_CLIENT_CONN_ERROR; silc_fsm_next(fsm, silc_client_st_connect_error); SILC_FSM_CALL_CONTINUE(fsm); return; @@ -88,7 +87,7 @@ static void silc_client_connect_callback(SilcNetStatus status, /* Connection created successfully */ SILC_LOG_DEBUG(("Connected")); - conn->stream = (void *)stream; + conn->internal->user_stream = stream; SILC_FSM_CALL_CONTINUE(fsm); } @@ -96,7 +95,7 @@ static void silc_client_connect_callback(SilcNetStatus status, static void silc_client_ke_verify_key_cb(SilcBool success, void *context) { - VerifyKeyContext verify = (VerifyKeyContext)context; + SilcVerifyKeyContext verify = context; SILC_LOG_DEBUG(("Start")); @@ -119,7 +118,7 @@ static void silc_client_ke_verify_key(SilcSKE ske, SilcFSMThread fsm = context; SilcClientConnection conn = silc_fsm_get_context(fsm); SilcClient client = conn->client; - VerifyKeyContext verify; + SilcVerifyKeyContext verify; /* If we provided repository for SKE and we got here the key was not found from the repository. */ @@ -176,10 +175,11 @@ static void silc_client_ke_completion(SilcSKE ske, conn->remote_host, silc_ske_map_status(status)); + conn->internal->status = SILC_CLIENT_CONN_ERROR_KE; silc_ske_free_rekey_material(rekey); silc_fsm_next(fsm, silc_client_st_connect_error); - SILC_FSM_CALL_CONTINUE(fsm); + SILC_FSM_CALL_CONTINUE_SYNC(fsm); return; } @@ -197,13 +197,11 @@ static void silc_client_ke_completion(SilcSKE ske, "Error during key exchange with %s: cannot use keys", conn->remote_host); - conn->callback(client, conn, SILC_CLIENT_CONN_ERROR_KE, 0, NULL, - conn->callback_context); - + conn->internal->status = SILC_CLIENT_CONN_ERROR_KE; silc_ske_free_rekey_material(rekey); silc_fsm_next(fsm, silc_client_st_connect_error); - SILC_FSM_CALL_CONTINUE(fsm); + SILC_FSM_CALL_CONTINUE_SYNC(fsm); return; } @@ -220,13 +218,11 @@ static void silc_client_ke_completion(SilcSKE ske, "Error during key exchange with %s: cannot use keys", conn->remote_host); - conn->callback(client, conn, SILC_CLIENT_CONN_ERROR_KE, 0, NULL, - conn->callback_context); - + conn->internal->status = SILC_CLIENT_CONN_ERROR_KE; silc_ske_free_rekey_material(rekey); silc_fsm_next(fsm, silc_client_st_connect_error); - SILC_FSM_CALL_CONTINUE(fsm); + SILC_FSM_CALL_CONTINUE_SYNC(fsm); return; } @@ -235,7 +231,7 @@ static void silc_client_ke_completion(SilcSKE ske, SILC_LOG_DEBUG(("Key Exchange completed")); /* Key exchange done */ - SILC_FSM_CALL_CONTINUE(fsm); + SILC_FSM_CALL_CONTINUE_SYNC(fsm); } /* Rekey protocol completion callback */ @@ -263,6 +259,8 @@ static void silc_client_rekey_completion(SilcSKE ske, conn->remote_host, silc_ske_map_status(status)); + silc_ske_free(conn->internal->ske); + conn->internal->ske = NULL; silc_fsm_finish(fsm); return; } @@ -270,7 +268,10 @@ static void silc_client_rekey_completion(SilcSKE ske, silc_ske_free_rekey_material(conn->internal->rekey); conn->internal->rekey = rekey; - SILC_LOG_DEBUG(("Rekey completed")); + silc_ske_free(conn->internal->ske); + conn->internal->ske = NULL; + + SILC_LOG_DEBUG(("Rekey completed conn %p", conn)); /* Rekey done */ silc_fsm_finish(fsm); @@ -278,21 +279,20 @@ static void silc_client_rekey_completion(SilcSKE ske, /* Callback called by application to return authentication data */ -static void silc_client_connect_auth_method(SilcBool success, - SilcAuthMethod auth_meth, - void *auth, SilcUInt32 auth_len, +static void silc_client_connect_auth_method(SilcAuthMethod auth_meth, + const void *auth, + SilcUInt32 auth_len, void *context) { SilcFSMThread fsm = context; SilcClientConnection conn = silc_fsm_get_context(fsm); - conn->internal->params.auth_method = SILC_AUTH_NONE; - - if (success) { - conn->internal->params.auth_method = auth_meth; - conn->internal->params.auth = auth; - conn->internal->params.auth_len = auth_len; - } + conn->internal->params.auth_method = auth_meth; + if (auth_meth == SILC_AUTH_PASSWORD) + conn->internal->params.auth = silc_memdup(auth, auth_len); + else + conn->internal->params.auth = (void *)auth; + conn->internal->params.auth_len = auth_len; SILC_FSM_CALL_CONTINUE(fsm); } @@ -307,6 +307,7 @@ static void silc_client_connect_auth_completion(SilcConnAuth connauth, SilcClientConnection conn = silc_fsm_get_context(fsm); SilcClient client = conn->client; + conn->internal->op = NULL; silc_connauth_free(connauth); if (!success) { @@ -315,12 +316,48 @@ static void silc_client_connect_auth_completion(SilcConnAuth connauth, client, conn, SILC_CLIENT_MESSAGE_ERROR, "Authentication failed"); - conn->callback(client, conn, SILC_CLIENT_CONN_ERROR_AUTH, 0, NULL, - conn->callback_context); + conn->internal->status = SILC_CLIENT_CONN_ERROR_AUTH; + conn->internal->error = SILC_STATUS_ERR_AUTH_FAILED; silc_fsm_next(fsm, silc_client_st_connect_error); } - SILC_FSM_CALL_CONTINUE(fsm); + SILC_FSM_CALL_CONTINUE_SYNC(fsm); +} + +/********************** CONNECTION_AUTH_REQUEST packet **********************/ + +/* Received connection authentication request packet. We get the + required authentication method here. */ + +SILC_FSM_STATE(silc_client_connect_auth_request) +{ + SilcClientConnection conn = fsm_context; + SilcPacket packet = state_context; + SilcUInt16 conn_type, auth_meth; + + if (!conn->internal->auth_request) { + silc_packet_free(packet); + return SILC_FSM_FINISH; + } + + /* Parse the payload */ + if (silc_buffer_unformat(&packet->buffer, + SILC_STR_UI_SHORT(&conn_type), + SILC_STR_UI_SHORT(&auth_meth), + SILC_STR_END) < 0) + auth_meth = SILC_AUTH_NONE; + + silc_packet_free(packet); + + SILC_LOG_DEBUG(("Resolved authentication method: %s", + (auth_meth == SILC_AUTH_NONE ? "none" : + auth_meth == SILC_AUTH_PASSWORD ? "passphrase" : + "public key"))); + conn->internal->params.auth_method = auth_meth; + + /* Continue authentication */ + silc_fsm_continue_sync(&conn->internal->event_thread); + return SILC_FSM_FINISH; } /*************************** Connect remote host ****************************/ @@ -330,12 +367,11 @@ static void silc_client_connect_auth_completion(SilcConnAuth connauth, SILC_TASK_CALLBACK(silc_client_connect_timeout) { SilcClientConnection conn = context; - SilcClient client = conn->client; SILC_LOG_DEBUG(("Connection timeout")); - conn->callback(client, conn, SILC_CLIENT_CONN_ERROR_TIMEOUT, 0, NULL, - conn->callback_context); + conn->internal->status = SILC_CLIENT_CONN_ERROR_TIMEOUT; + conn->internal->error = SILC_STATUS_ERR_TIMEDOUT; silc_fsm_next(&conn->internal->event_thread, silc_client_st_connect_error); silc_fsm_continue_sync(&conn->internal->event_thread); @@ -346,7 +382,6 @@ SILC_TASK_CALLBACK(silc_client_connect_timeout) SILC_FSM_STATE(silc_client_st_connect) { SilcClientConnection conn = fsm_context; - SilcClient client = conn->client; SILC_LOG_DEBUG(("Connecting to %s:%d", conn->remote_host, conn->remote_port)); @@ -366,8 +401,7 @@ SILC_FSM_STATE(silc_client_st_connect) if (!conn->internal->params.local_ip) { /** IP address not given */ SILC_LOG_ERROR(("Local UDP IP address not specified")); - conn->callback(client, conn, SILC_CLIENT_CONN_ERROR, 0, NULL, - conn->callback_context); + conn->internal->status = SILC_CLIENT_CONN_ERROR; silc_fsm_next(fsm, silc_client_st_connect_error); return SILC_FSM_CONTINUE; } @@ -400,15 +434,20 @@ SILC_FSM_STATE(silc_client_st_connect_set_stream) SilcClientConnection conn = fsm_context; SilcClient client = conn->client; + if (conn->internal->disconnected) { + /** Disconnected */ + silc_fsm_next(fsm, silc_client_st_connect_error); + return SILC_FSM_CONTINUE; + } + /* Create packet stream */ conn->stream = silc_packet_stream_create(client->internal->packet_engine, conn->internal->schedule, - (SilcStream)conn->stream); + conn->internal->user_stream); if (!conn->stream) { /** Cannot create packet stream */ SILC_LOG_DEBUG(("Could not create packet stream")); - conn->callback(client, conn, SILC_CLIENT_CONN_ERROR, 0, NULL, - conn->callback_context); + conn->internal->status = SILC_CLIENT_CONN_ERROR; silc_fsm_next(fsm, silc_client_st_connect_error); return SILC_FSM_CONTINUE; } @@ -427,6 +466,7 @@ SILC_FSM_STATE(silc_client_st_connect_key_exchange) SilcClientConnection conn = fsm_context; SilcClient client = conn->client; SilcSKEParamsStruct params; + SilcClientID cid; SILC_LOG_DEBUG(("Starting key exchange protocol")); @@ -437,8 +477,7 @@ SILC_FSM_STATE(silc_client_st_connect_key_exchange) conn->public_key, conn->private_key, fsm); if (!conn->internal->ske) { /** Out of memory */ - conn->callback(client, conn, SILC_CLIENT_CONN_ERROR_KE, 0, NULL, - conn->callback_context); + conn->internal->status = SILC_CLIENT_CONN_ERROR_KE; silc_fsm_next(fsm, silc_client_st_connect_error); return SILC_FSM_CONTINUE; } @@ -449,6 +488,7 @@ SILC_FSM_STATE(silc_client_st_connect_key_exchange) /* Set up key exchange parameters */ params.version = client->internal->silc_client_version; + params.timeout_secs = conn->internal->params.timeout_secs; params.flags = SILC_SKE_SP_FLAG_MUTUAL; if (conn->internal->params.pfs) params.flags |= SILC_SKE_SP_FLAG_PFS; @@ -465,7 +505,13 @@ SILC_FSM_STATE(silc_client_st_connect_key_exchange) silc_fsm_next(fsm, silc_client_st_connect_setup_udp); else /** Run key exchange (TCP) */ - silc_fsm_next(fsm, silc_client_st_connect_auth); + silc_fsm_next(fsm, silc_client_st_connect_auth_resolve); + + /* Old server version requires empty Client ID in packets. Remove this + backwards support somepoint after 1.1 server is released. */ + memset(&cid, 0, sizeof(cid)); + cid.ip.data_len = 4; + silc_packet_set_ids(conn->stream, SILC_ID_CLIENT, &cid, 0, NULL); SILC_FSM_CALL(conn->internal->op = silc_ske_initiator(conn->internal->ske, conn->stream, @@ -478,12 +524,17 @@ SILC_FSM_STATE(silc_client_st_connect_key_exchange) SILC_FSM_STATE(silc_client_st_connect_setup_udp) { SilcClientConnection conn = fsm_context; - SilcClient client = conn->client; SilcStream stream, old; SilcSKESecurityProperties prop; SILC_LOG_DEBUG(("Setup UDP SILC session")); + if (conn->internal->disconnected) { + /** Disconnected */ + silc_fsm_next(fsm, silc_client_st_connect_error); + return SILC_FSM_CONTINUE; + } + /* Create new UDP stream */ prop = silc_ske_get_security_properties(conn->internal->ske); stream = silc_net_udp_connect(conn->internal->params.local_ip, @@ -492,16 +543,14 @@ SILC_FSM_STATE(silc_client_st_connect_setup_udp) conn->internal->schedule); if (!stream) { /** Cannot create UDP stream */ - conn->callback(client, conn, SILC_CLIENT_CONN_ERROR, 0, NULL, - conn->callback_context); + conn->internal->status = SILC_CLIENT_CONN_ERROR; silc_fsm_next(fsm, silc_client_st_connect_error); return SILC_FSM_CONTINUE; } /* Set the new stream to packet stream */ old = silc_packet_stream_get_stream(conn->stream); - silc_packet_stream_set_stream(conn->stream, stream, - conn->internal->schedule); + silc_packet_stream_set_stream(conn->stream, stream); silc_packet_stream_set_iv_included(conn->stream); silc_packet_set_sid(conn->stream, 0); @@ -509,34 +558,70 @@ SILC_FSM_STATE(silc_client_st_connect_setup_udp) silc_stream_destroy(old); /** Start authentication */ - silc_fsm_next(fsm, silc_client_st_connect_auth); + silc_fsm_next(fsm, silc_client_st_connect_auth_resolve); return SILC_FSM_CONTINUE; } -/* Get authentication method to be used in authentication protocol */ +/* Resolve authentication method to be used in authentication protocol */ + +SILC_FSM_STATE(silc_client_st_connect_auth_resolve) +{ + SilcClientConnection conn = fsm_context; + + SILC_LOG_DEBUG(("Resolve authentication method")); + + if (conn->internal->disconnected) { + /** Disconnected */ + silc_fsm_next(fsm, silc_client_st_connect_error); + return SILC_FSM_CONTINUE; + } + + /* If authentication method and data is set, use them */ + if (conn->internal->params.auth_set) { + /** Got authentication data */ + silc_fsm_next(fsm, silc_client_st_connect_auth_start); + return SILC_FSM_CONTINUE; + } + + /* Send connection authentication request packet */ + silc_packet_send_va(conn->stream, + SILC_PACKET_CONNECTION_AUTH_REQUEST, 0, + SILC_STR_UI_SHORT(SILC_CONN_CLIENT), + SILC_STR_UI_SHORT(SILC_AUTH_NONE), + SILC_STR_END); + + /** Wait for authentication method */ + conn->internal->auth_request = TRUE; + conn->internal->params.auth_method = SILC_AUTH_NONE; + silc_fsm_next_later(fsm, silc_client_st_connect_auth_data, 2, 0); + return SILC_FSM_WAIT; +} + +/* Get authentication data to be used in authentication protocol */ -SILC_FSM_STATE(silc_client_st_connect_auth) +SILC_FSM_STATE(silc_client_st_connect_auth_data) { SilcClientConnection conn = fsm_context; SilcClient client = conn->client; SILC_LOG_DEBUG(("Get authentication data")); - silc_fsm_next(fsm, silc_client_st_connect_auth_start); + if (conn->internal->disconnected) { + /** Disconnected */ + silc_fsm_next(fsm, silc_client_st_connect_error); + return SILC_FSM_CONTINUE; + } - /* If authentication data not provided, ask from application */ - if (!conn->internal->params.auth_set) - SILC_FSM_CALL(client->internal->ops->get_auth_method( + conn->internal->auth_request = FALSE; + + /** Get authentication data */ + silc_fsm_next(fsm, silc_client_st_connect_auth_start); + SILC_FSM_CALL(client->internal->ops->get_auth_method( client, conn, conn->remote_host, conn->remote_port, + conn->internal->params.auth_method, silc_client_connect_auth_method, fsm)); - - if (conn->internal->params.auth_method == SILC_AUTH_PUBLIC_KEY) - conn->internal->params.auth = conn->private_key; - - /* We have authentication data */ - return SILC_FSM_CONTINUE; } /* Start connection authentication with remote host */ @@ -544,19 +629,28 @@ SILC_FSM_STATE(silc_client_st_connect_auth) SILC_FSM_STATE(silc_client_st_connect_auth_start) { SilcClientConnection conn = fsm_context; - SilcClient client = conn->client; SilcConnAuth connauth; SILC_LOG_DEBUG(("Starting connection authentication protocol")); + if (conn->internal->disconnected) { + /** Disconnected */ + silc_fsm_next(fsm, silc_client_st_connect_error); + return SILC_FSM_CONTINUE; + } + + /* We always use the same key for connection authentication and SKE */ + if (conn->internal->params.auth_method == SILC_AUTH_PUBLIC_KEY) + conn->internal->params.auth = conn->private_key; + /* Allocate connection authentication protocol */ connauth = silc_connauth_alloc(conn->internal->schedule, conn->internal->ske, conn->internal->params.rekey_secs); if (!connauth) { /** Out of memory */ - conn->callback(client, conn, SILC_CLIENT_CONN_ERROR_AUTH, 0, NULL, - conn->callback_context); + conn->internal->status = SILC_CLIENT_CONN_ERROR_AUTH; + conn->internal->error = SILC_STATUS_ERR_AUTH_FAILED; silc_fsm_next(fsm, silc_client_st_connect_error); return SILC_FSM_CONTINUE; } @@ -579,15 +673,33 @@ SILC_FSM_STATE(silc_client_st_connected) SilcClientConnection conn = fsm_context; SilcClient client = conn->client; - SILC_LOG_DEBUG(("Connection established")); + /* Get SILC protocol version remote supports */ + silc_ske_parse_version(conn->internal->ske, &conn->internal->remote_version, + NULL, NULL, NULL, NULL); silc_ske_free(conn->internal->ske); conn->internal->ske = NULL; + if (!conn->internal->params.auth_set && + conn->internal->params.auth_method == SILC_AUTH_PASSWORD && + conn->internal->params.auth) { + silc_free(conn->internal->params.auth); + conn->internal->params.auth = NULL; + } + + if (conn->internal->disconnected) { + /** Disconnected */ + silc_fsm_next(fsm, silc_client_st_connect_error); + return SILC_FSM_CONTINUE; + } + + SILC_LOG_DEBUG(("Connection established")); + /* Install rekey timer */ - silc_schedule_task_add_timeout(conn->internal->schedule, - silc_client_rekey_timer, conn, - conn->internal->params.rekey_secs, 0); + if (conn->type != SILC_CONN_CLIENT) + silc_schedule_task_add_timeout(conn->internal->schedule, + silc_client_rekey_timer, conn, + conn->internal->params.rekey_secs, 0); /* If we connected to server, now register to network. */ if (conn->type == SILC_CONN_SERVER && @@ -613,6 +725,9 @@ SILC_FSM_STATE(silc_client_st_connected) conn->callback(client, conn, SILC_CLIENT_CONN_SUCCESS, 0, NULL, conn->callback_context); + silc_async_free(conn->internal->cop); + conn->internal->cop = NULL; + return SILC_FSM_FINISH; } @@ -630,7 +745,7 @@ SILC_FSM_STATE(silc_client_st_connect_error) /* Signal to close connection */ if (!conn->internal->disconnected) { conn->internal->disconnected = TRUE; - SILC_FSM_SEMA_POST(&conn->internal->wait_event); + SILC_FSM_EVENT_SIGNAL(&conn->internal->wait_event); } silc_schedule_task_del_by_all(conn->internal->schedule, 0, @@ -648,8 +763,11 @@ SILC_TASK_CALLBACK(silc_client_rekey_timer) SilcClientConnection conn = context; /* Signal to start rekey */ - conn->internal->rekeying = TRUE; - SILC_FSM_SEMA_POST(&conn->internal->wait_event); + if (!silc_fsm_is_started(&conn->internal->event_thread)) { + conn->internal->rekey_responder = FALSE; + conn->internal->rekeying = TRUE; + SILC_FSM_EVENT_SIGNAL(&conn->internal->wait_event); + } /* Reinstall rekey timer */ silc_schedule_task_add_timeout(conn->internal->schedule, @@ -664,13 +782,15 @@ SILC_FSM_STATE(silc_client_st_rekey) SilcClientConnection conn = fsm_context; SilcClient client = conn->client; - SILC_LOG_DEBUG(("Rekey")); + SILC_LOG_DEBUG(("Rekey conn %p", conn)); + + if (conn->internal->disconnected) + return SILC_FSM_FINISH; /* Allocate SKE */ conn->internal->ske = - silc_ske_alloc(client->rng, conn->internal->schedule, - conn->internal->params.repository, - conn->public_key, conn->private_key, fsm); + silc_ske_alloc(client->rng, conn->internal->schedule, NULL, + conn->public_key, NULL, fsm); if (!conn->internal->ske) return SILC_FSM_FINISH; @@ -688,5 +808,6 @@ SILC_FSM_STATE(silc_client_st_rekey) SILC_FSM_CALL(conn->internal->op = silc_ske_rekey_responder( conn->internal->ske, conn->stream, - conn->internal->rekey)); + conn->internal->rekey, + NULL)); }